Description
Owen Leonard
2016-05-26 15:01:27 UTC
Created attachment 69454 [details] [review] Bug 16603: When processing uploaded offline circulation file, "apply directly" option fails This patch is a temporary mitigation of whatever the real problem is. The patch hides the "Apply directly" button so that the option isn't available. To test, apply the patch and generate a .koc file with some transactions. Upload the file via Circulation -> Offline circulation file upload. After the file is uploaded, you should see only a "Add to offline circulation queue" button, which should work correctly. Created attachment 70528 [details] [review] Bug 16603: When processing uploaded offline circulation file, "apply directly" option fails This patch is a temporary mitigation of whatever the real problem is. The patch hides the "Apply directly" button so that the option isn't available. To test, apply the patch and generate a .koc file with some transactions. Upload the file via Circulation -> Offline circulation file upload. After the file is uploaded, you should see only a "Add to offline circulation queue" button, which should work correctly. Signed-off-by: Grace Smyth <gracesmythh@gmail.com> Created attachment 70746 [details] [review] Bug 16603: When processing uploaded offline circulation file, "apply directly" option fails This patch is a temporary mitigation of whatever the real problem is. The patch hides the "Apply directly" button so that the option isn't available. To test, apply the patch and generate a .koc file with some transactions. Upload the file via Circulation -> Offline circulation file upload. After the file is uploaded, you should see only a "Add to offline circulation queue" button, which should work correctly. Signed-off-by: Grace Smyth <gracesmythh@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 70747 [details] [review] Bug 16603: (QA Follow-up) Add a FIXME Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Would be better to fix, but I didn't see the problem in a quick look. This prevents the error for user so PQA (In reply to Nick Clemens from comment #5) > Would be better to fix, but I didn't see the problem in a quick look. This > prevents the error for user so PQA Can someone open another bug report please? Pushed to master for 18.05, thanks to everybody involved! Awesome work all! Pushed to Stable for 17.11.02 Pushed to 17.05.x for v17.05.09 |