Summary: | Missing entity nbsp in some XML files | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Templates | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | bgkriegel, f.demians, julian.maurice, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 7141 | ||
Bug Blocks: | |||
Attachments: |
Bug 16608 - Add xsld extension to t/00-valid-xml.t
Bug 16608 - Add xsd extension to t/00-valid-xml.t Bug 16608 - Missing entity nbsp in some XML files [SIGNED-OFF] Bug 16608 - Add xsd extension to t/00-valid-xml.t [SIGNED-OFF] Bug 16608 - Missing entity nbsp in some XML files Bug 16608 - Add xsd extension to t/00-valid-xml.t Bug 16608 - Missing entity nbsp in some XML files |
Description
Fridolin Somers
2016-05-27 08:33:55 UTC
Created attachment 51862 [details] [review] Bug 16608 - Add xsld extension to t/00-valid-xml.t Created attachment 51863 [details] [review] Bug 16608 - Add xsd extension to t/00-valid-xml.t Created attachment 51864 [details] [review] Bug 16608 - Missing entity nbsp in some XML files The special character "non breaking space" is not contained in XML syntax by default. So we add it in the file header : <!DOCTYPE stylesheet [<!ENTITY nbsp " " >]> Even if the source code files do no contain this character, it can be that translated files contain it. French for example "Titre :". This entity is missing in all files in koha-tmpl/intranet-tmpl/prog/en/data/ and in some files of koha-tmpl/intranet-tmpl/prog/en/xslt. Test plan : - generate French templates: cd misc/translator ./translate install fr-FR cd ../.. - run test: prove -v t/00-valid-xml.t you get failing error message - apply this patch - translate again - run test again: it passes Created attachment 51886 [details] [review] [SIGNED-OFF] Bug 16608 - Add xsd extension to t/00-valid-xml.t Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Created attachment 51887 [details] [review] [SIGNED-OFF] Bug 16608 - Missing entity nbsp in some XML files The special character "non breaking space" is not contained in XML syntax by default. So we add it in the file header : <!DOCTYPE stylesheet [<!ENTITY nbsp " " >]> Even if the source code files do no contain this character, it can be that translated files contain it. French for example "Titre :". This entity is missing in all files in koha-tmpl/intranet-tmpl/prog/en/data/ and in some files of koha-tmpl/intranet-tmpl/prog/en/xslt. Test plan : - generate French templates: cd misc/translator ./translate install fr-FR cd ../.. - run test: prove -v t/00-valid-xml.t you get failing error message - apply this patch - translate again - run test again: it passes Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described following test plan Tes pass, no errors. Created attachment 52231 [details] [review] Bug 16608 - Add xsd extension to t/00-valid-xml.t Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 52232 [details] [review] Bug 16608 - Missing entity nbsp in some XML files The special character "non breaking space" is not contained in XML syntax by default. So we add it in the file header : <!DOCTYPE stylesheet [<!ENTITY nbsp " " >]> Even if the source code files do no contain this character, it can be that translated files contain it. French for example "Titre :". This entity is missing in all files in koha-tmpl/intranet-tmpl/prog/en/data/ and in some files of koha-tmpl/intranet-tmpl/prog/en/xslt. Test plan : - generate French templates: cd misc/translator ./translate install fr-FR cd ../.. - run test: prove -v t/00-valid-xml.t you get failing error message - apply this patch - translate again - run test again: it passes Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described following test plan Tes pass, no errors. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 16.11, thanks Frido! Pushed in 16.05. Will be in 16.05.01. Patches pushed to 3.22.x, will be in 3.22.8 |