| Summary: | Catch warning from Koha::Hold in Hold.t | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Test Suite | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | f.demians, julian.maurice, kyle, mtompset, srdjan |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 16609: Catch warning from Koha::Hold in Hold.t
Bug 16609: Catch warning from Koha::Hold in Hold.t Bug 16609: Catch warning from Koha::Hold in Hold.t |
||
|
Description
Marcel de Rooy
2016-05-27 12:07:11 UTC
Created attachment 51874 [details] [review] Bug 16609: Catch warning from Koha::Hold in Hold.t Before this patch, the suspend step triggers a warn from Koha::Hold. Now we catch it. Test plan: Run the test. Do not see the warning about unable to suspend. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> That test is failing for me with DBD::mysql::st execute failed: Field 'lowestPriority' doesn't have a default value [for Statement "INSERT INTO `reserves` ( `biblionumber`, `borrowernumber`, `branchcode`, `itemnumber`, `suspend`, `waitingdate`) VALUES ( ?, ?, ?, ?, ?, ? )" with ParamValues: 0='6644', 1='386', 2='EP3', 3='19635', 4=0, 5='2000-01-01'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1834. DBIx::Class::Storage::DBI::_dbh_execute(): Field 'lowestPriority' doesn't have a default value at Koha/Object.pm line 109 Srdjan, Thx for testing. Strange that it fails. You seem to fail already before reaching my adjustment. Should fail without my patch too? I am not having any problem: t/db_dependent/Hold.t .. ok All tests successful. Files=1, Tests=32, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.38 cusr 0.10 csys = 1.53 CPU) Result: PASS Oh yes, definitely fails for me on the master branch, nothing to do with the patch. Created attachment 51926 [details] [review] Bug 16609: Catch warning from Koha::Hold in Hold.t Before this patch, the suspend step triggers a warn from Koha::Hold. Now we catch it. Test plan: Run the test. Do not see the warning about unable to suspend. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> NOTE: Nice clean up! Signed-off-by: Mark Tompsett <mtompset@hotmail.com> (In reply to M. Tompsett from comment #5) > NOTE: Nice clean up! > > Signed-off-by: Mark Tompsett <mtompset@hotmail.com> This was on a fresh install. Created attachment 52117 [details] [review] Bug 16609: Catch warning from Koha::Hold in Hold.t Before this patch, the suspend step triggers a warn from Koha::Hold. Now we catch it. Test plan: Run the test. Do not see the warning about unable to suspend. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> NOTE: Nice clean up! Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for Koha 16.11, thanks Marcel! Pushed in 16.05. Will be in 16.05.01. Not needed in 3.22.x |