Bug 16641

Summary: Update Novelist in opac to use updated call to fetch content
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: OPACAssignee: Nick Clemens (kidclamp) <nick>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: amy, jdemuth, katrin.fischer, kholt, kyle, m.de.rooy, nick, nicole
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
With this pach you don't see anymore a empty tab if Novelist Select ia active in Opac.
Version(s) released in:
Attachments: Bug 16641 - Update Novelist in opac to use updated call to fetch content
Bug 16641: Update Novelist in OPAC to use updated call to fetch content
Bug 16641: Update Novelist in OPAC to use updated call to fetch content
[PASSED QA] Bug 16641: Update Novelist in OPAC to use updated call to fetch content

Description Nick Clemens (kidclamp) 2016-06-03 01:24:31 UTC
Moved from bug 11606:
3) Update the Koha OPAC code to use loadContentForQuery rather than the deprecated loadContentForISBN

Additionally only display content if results are retrieved
Comment 1 Nick Clemens (kidclamp) 2016-06-03 01:27:25 UTC Comment hidden (obsolete)
Comment 2 Jesse Weaver 2016-06-14 15:43:00 UTC Comment hidden (obsolete)
Comment 3 Nicole C. Engard 2016-06-14 15:54:03 UTC
Created attachment 52391 [details] [review]
Bug 16641: Update Novelist in OPAC to use updated call to fetch content

To test:
1 - Enable novelistselect content in the opac
2 - Find a record with novelist content, confirm it displays in tabs ro
above or below accoring to pref
3 - Find a record without novelist content, note you get an empty tab
4 - Apply patch
5 - Ensure results have not changed for items with content
6 - Ensure tab does not display for item with no content

Sponsored by:
   Walla Walla Public Library (http://www.wallawallapubliclibrary.org/)
   Los Gatos Library (http://www.losgatosca.gov/42/Los-Gatos-Library)

Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Internal signoff.

Signed-off-by: Dwayne Nance <dnance@ebsco.com>

Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov>
Comment 4 Marcel de Rooy 2016-08-19 06:09:54 UTC
Any test credentials available to test this?
Comment 5 Katrin Fischer 2016-10-24 13:24:52 UTC
This only touches Novelist Select related code, changes are consistent, no regressions found on the detail page.

Credentials to test this properly would still be good :)
Comment 6 Katrin Fischer 2016-10-24 13:26:06 UTC
Created attachment 56770 [details] [review]
[PASSED QA] Bug 16641: Update Novelist in OPAC to use updated call to fetch content

To test:
1 - Enable novelistselect content in the opac
2 - Find a record with novelist content, confirm it displays in tabs ro
above or below accoring to pref
3 - Find a record without novelist content, note you get an empty tab
4 - Apply patch
5 - Ensure results have not changed for items with content
6 - Ensure tab does not display for item with no content

Sponsored by:
   Walla Walla Public Library (http://www.wallawallapubliclibrary.org/)
   Los Gatos Library (http://www.losgatosca.gov/42/Los-Gatos-Library)

Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Internal signoff.

Signed-off-by: Dwayne Nance <dnance@ebsco.com>

Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov>

Signed-off-by: Katrin Fischer  <katrin.fischer@bsz-bw.de>
Comment 7 Kyle M Hall 2016-10-28 15:28:17 UTC
Pushed to master for 16.11, thanks Nick!