Summary: | Unused variable and function call in circulation.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi <tomascohen> |
Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | f.demians, jonathan.druart, julian.maurice, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 16667: Unused variable and function call in circulation.pl
[SIGNED-OFF] Bug 16667: Unused variable and function call in circulation.pl Bug 16667: Unused variable and function call in circulation.pl |
Description
Tomás Cohen Arazi
2016-06-05 11:45:02 UTC
Created attachment 52062 [details] [review] Bug 16667: Unused variable and function call in circulation.pl This patch removes an unused occurence of the $branches variable. Probably a leftover from a recent rewrite. To test: - Run: $ git grep '$branches' circ/circulation.pl => FAIL: Only on occurence of the variable - Apply the patch - Run: $ git grep '$branches' circ/circulation.pl => SUCCESS: The variable has been removed - Sign off :-D Regards Created attachment 52067 [details] [review] [SIGNED-OFF] Bug 16667: Unused variable and function call in circulation.pl This patch removes an unused occurence of the $branches variable. Probably a leftover from a recent rewrite. To test: - Run: $ git grep '$branches' circ/circulation.pl => FAIL: Only on occurence of the variable - Apply the patch - Run: $ git grep '$branches' circ/circulation.pl => SUCCESS: The variable has been removed - Sign off :-D Regards Signed-off-by: Srdjan <srdjan@catalyst.net.nz> (In reply to Tomás Cohen Arazi from comment #1) > This patch removes an unused occurence of the $branches variable. Probably a > leftover from a recent rewrite. Not at all, it's not used since... commit 2ffd5b7228f4e638583162d483e1dd2febeafe1b Date: Fri Mar 9 14:28:54 2007 +0000 :) Created attachment 52112 [details] [review] Bug 16667: Unused variable and function call in circulation.pl This patch removes an unused occurence of the $branches variable. Probably a leftover from a recent rewrite. To test: - Run: $ git grep '$branches' circ/circulation.pl => FAIL: Only on occurence of the variable - Apply the patch - Run: $ git grep '$branches' circ/circulation.pl => SUCCESS: The variable has been removed - Sign off :-D Regards Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for Koha 16.11, thanks Tomas! Pushed in 16.05. Will be in 16.05.01. Patch pushed to 3.22.x, will be in 3.22.8 |