Summary: | fix breakage of t/Languages.t | ||
---|---|---|---|
Product: | Koha | Reporter: | Galen Charlton <gmcharlt> |
Component: | Test Suite | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | normal | ||
Priority: | P5 - low | CC: | f.demians, jonathan.druart, julian.maurice, kyle, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 16088 | ||
Bug Blocks: | |||
Attachments: |
Bug 16675: fix breakage of t/Languages.t
Bug 16675: fix breakage of t/Languages.t Bug 16675: fix breakage of t/Languages.t Bug 16675: fix breakage of t/Languages.t |
Description
Galen Charlton
2016-06-07 02:03:57 UTC
Created attachment 52109 [details] [review] Bug 16675: fix breakage of t/Languages.t This patch fixes test breakage introduced by the patch for bug 16088, which added caching of getlanguages(). Upon inspection, it looks like the patch for 16088 does not introduce a regression on bug 10560, so this patch adds a couple cache-clearings. To test ------- [1] Verify that t/Languages.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Created attachment 52125 [details] [review] Bug 16675: fix breakage of t/Languages.t This patch fixes test breakage introduced by the patch for bug 16088, which added caching of getlanguages(). Upon inspection, it looks like the patch for 16088 does not introduce a regression on bug 10560, so this patch adds a couple cache-clearings. To test ------- [1] Verify that t/Languages.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 52128 [details] [review] Bug 16675: fix breakage of t/Languages.t This patch fixes test breakage introduced by the patch for bug 16088, which added caching of getlanguages(). Upon inspection, it looks like the patch for 16088 does not introduce a regression on bug 10560, so this patch adds a couple cache-clearings. To test ------- [1] Verify that t/Languages.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 52160 [details] [review] Bug 16675: fix breakage of t/Languages.t This patch fixes test breakage introduced by the patch for bug 16088, which added caching of getlanguages(). Upon inspection, it looks like the patch for 16088 does not introduce a regression on bug 10560, so this patch adds a couple cache-clearings. To test ------- [1] Verify that t/Languages.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 16.11, thanks Galen! Pushed in 16.05. Will be in 16.05.01. Frédéric, you should probably push bug 16088 as well, because it introduce Koha::Cache::Memory::Lite (which is used by this patch) (In reply to Julian Maurice from comment #7) > Frédéric, you should probably push bug 16088 as well, because it introduce > Koha::Cache::Memory::Lite (which is used by this patch) I was reluctant to, but with a failing test, I have no choice. Thanks Julian. Patch pushed to 3.22.x, will be in 3.22.8 (In reply to Frédéric Demians from comment #8) > (In reply to Julian Maurice from comment #7) > > Frédéric, you should probably push bug 16088 as well, because it introduce > > Koha::Cache::Memory::Lite (which is used by this patch) > > I was reluctant to, but with a failing test, I have no choice. Thanks Julian. I do not understand: this patch (16675) fixes a test which fails because of bug 16088. |