Description
Theodoros Theodoropoulos
2016-06-07 07:56:48 UTC
Bug 8956 aka Bug 12375 was not backported to 3.22.x branch; looks like it's indeed an issue in 16.05 and master, but not in the 3.22? Created attachment 52177 [details] [review] Bug 16678: updatedatabase.pl 3.23.00.006 DB upgrade crashes if subscription_numberpatterns.numberingmethod contains parentheses It seems that if subscription_numberpatterns.numberingmethod contains parentheses, updatedatabase.pl crashes when running the 3.23.00.006 DB upgrade snippet, with the following error: [Mon Jun 6 09:06:54 2016] updatedatabase.pl: Unmatched ( in regex; marked by <-- HERE in m/ ( <-- HERE / at /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 11498. Steps to reproduce: 1/ Have a Koha DB version<3.23.00.006 2/ Create a subscription numbering with parentheses in it: ie "Vol. (Month, Year)" with pattern Vol. {X} ({Y}, {Z}) 3/ Add some serials using that numbering method so that serialseq is filled in DB: ie "Vol. 16 (February, 2015)" 4/ Run the updatedatabase.pl script either from the cli or just start the webinstaller 5/ The error is produced To test: 1/ apply patch 2/ try to reproduce this issue once again, should be fixed now 3/ have a look at the code, make sure the changes are consistent @Jacek although not a 'proper' test nor a 'signoff' (because I cannot easily degrade the DB version) I would like to share that I've applied your patch in the appropriate part of the updatedatabase.pl and run the code snippet for subscriptions that contained parentheses, and everything worked as expected! Let's hope that someone else will manage to properly signoff your code so that it goes to QA and put to master (before anyone upgrading to 16.05 faces this issue) Thanks! Created attachment 52180 [details] [review] Bug 16678: updatedatabase.pl 3.23.00.006 DB upgrade crashes if subscription_numberpatterns.numberingmethod contains parentheses It seems that if subscription_numberpatterns.numberingmethod contains parentheses, updatedatabase.pl crashes when running the 3.23.00.006 DB upgrade snippet, with the following error: [Mon Jun 6 09:06:54 2016] updatedatabase.pl: Unmatched ( in regex; marked by <-- HERE in m/ ( <-- HERE / at /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 11498. Steps to reproduce: 1/ Have a Koha DB version<3.23.00.006 2/ Create a subscription numbering with parentheses in it: ie "Vol. (Month, Year)" with pattern Vol. {X} ({Y}, {Z}) 3/ Add some serials using that numbering method so that serialseq is filled in DB: ie "Vol. 16 (February, 2015)" 4/ Run the updatedatabase.pl script either from the cli or just start the webinstaller 5/ The error is produced To test: 1/ apply patch 2/ try to reproduce this issue once again, should be fixed now 3/ have a look at the code, make sure the changes are consistent Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 52186 [details] [review] Bug 16678: updatedatabase.pl 3.23.00.006 DB upgrade crashes if subscription_numberpatterns.numberingmethod contains parentheses It seems that if subscription_numberpatterns.numberingmethod contains parentheses, updatedatabase.pl crashes when running the 3.23.00.006 DB upgrade snippet, with the following error: [Mon Jun 6 09:06:54 2016] updatedatabase.pl: Unmatched ( in regex; marked by <-- HERE in m/ ( <-- HERE / at /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 11498. Steps to reproduce: 1/ Have a Koha DB version<3.23.00.006 2/ Create a subscription numbering with parentheses in it: ie "Vol. (Month, Year)" with pattern Vol. {X} ({Y}, {Z}) 3/ Add some serials using that numbering method so that serialseq is filled in DB: ie "Vol. 16 (February, 2015)" 4/ Run the updatedatabase.pl script either from the cli or just start the webinstaller 5/ The error is produced To test: 1/ apply patch 2/ try to reproduce this issue once again, should be fixed now 3/ have a look at the code, make sure the changes are consistent Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Note: I have not tested the patch, but the diff looks good. Pushed to master for 16.11, thanks Jacek! Pushed in 16.05. Will be in 16.05.01. Not needed in 3.22.x |