Summary: | Library name are not displayed for holds in transit | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | f.demians, julian.maurice, kyle, nick, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 13918 | ||
Bug Blocks: | |||
Attachments: |
Bug 16680: (bug 13918 follow-up) Display library names for holds in transit
Bug 16680: (bug 13918 follow-up) Display library names for holds in transit [PASSED QA] Bug 16680: (bug 13918 follow-up) Display library names for holds in transit |
Description
Jonathan Druart
2016-06-07 09:47:17 UTC
Created attachment 52116 [details] [review] Bug 16680: (bug 13918 follow-up) Display library names for holds in transit Regression introduced by bug 13918: the library names are not displayed anymore for holds in transit. They are 2 warns in the logs: No method wbrname! at /home/koha/src/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt line 603. No method wbrcd! at /home/koha/src/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt line 603. Test plan: Make sure you have holds in transit and go the opac-user.pl In the "Holds" tab, you should see "Item in transit to LIBRARY NAME" I note this here because it might be related: opac-user.pl: No method frombranch! at /usr/share/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt line 607 In OPAC I get "Item in transit from since" (with and without this patch) (In reply to Marc Véron from comment #2) > I note this here because it might be related: > opac-user.pl: No method frombranch! at > /usr/share/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt > line 607 > > In OPAC I get "Item in transit from since" > (with and without this patch) Yes it's related to bug 13918 as well, but I don't know how to fix it easily and Kyle may have fixed it already somewhere else. Could you please open another bug report and link it to 13918? (In reply to Jonathan Druart from comment #3) > (In reply to Marc Véron from comment #2) > > I note this here because it might be related: > > opac-user.pl: No method frombranch! at > > /usr/share/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt > > line 607 > > > > In OPAC I get "Item in transit from since" > > (with and without this patch) > > Yes it's related to bug 13918 as well, but I don't know how to fix it easily > and Kyle may have fixed it already somewhere else. Could you please open > another bug report and link it to 13918? See Bug 16686 - Fix "Item in transit from since" in Holds tab Created attachment 52158 [details] [review] Bug 16680: (bug 13918 follow-up) Display library names for holds in transit Regression introduced by bug 13918: the library names are not displayed anymore for holds in transit. They are 2 warns in the logs: No method wbrname! at /home/koha/src/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt line 603. No method wbrcd! at /home/koha/src/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt line 603. Test plan: Make sure you have holds in transit and go the opac-user.pl In the "Holds" tab, you should see "Item in transit to LIBRARY NAME" Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 52544 [details] [review] [PASSED QA] Bug 16680: (bug 13918 follow-up) Display library names for holds in transit Regression introduced by bug 13918: the library names are not displayed anymore for holds in transit. They are 2 warns in the logs: No method wbrname! at /home/koha/src/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt line 603. No method wbrcd! at /home/koha/src/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt line 603. Test plan: Make sure you have holds in transit and go the opac-user.pl In the "Holds" tab, you should see "Item in transit to LIBRARY NAME" Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 16.11,t thanks Jonathan! Pushed in 16.05. Will be in 16.05.02. Not needed in 3.22.x |