Bug 16693

Summary: reserve/renewscript.pl is not used and should be removed
Product: Koha Reporter: Julian Maurice <julian.maurice>
Component: Architecture, internals, and plumbingAssignee: Julian Maurice <julian.maurice>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: f.demians, kyle, srdjan
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 11703    
Bug Blocks:    
Attachments: Bug 16693: Remove reserve/renewscript.pl
[SIGNED-OFF] Bug 16693: Remove reserve/renewscript.pl
Bug 16693: Remove reserve/renewscript.pl

Description Julian Maurice 2016-06-08 11:47:05 UTC
It seems that reserve/renewscript.pl is not used since bug 11703.
This script should be removed.
Comment 1 Julian Maurice 2016-06-08 11:48:27 UTC Comment hidden (obsolete)
Comment 2 Julian Maurice 2016-06-08 11:51:23 UTC
Test plan:
1. Confirm that no occurences of this script remains in the code (git grep renewscript)
2. Check that you can still renew loans (which is what this is script was supposed to do... I guess ?)
Comment 3 Srdjan Jankovic 2016-06-14 04:19:44 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2016-06-14 16:01:59 UTC
Created attachment 52396 [details] [review]
Bug 16693: Remove reserve/renewscript.pl

It is not used since bug 11703

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Kyle M Hall (khall) 2016-06-17 15:58:52 UTC
Pushed to master for Koha 16.11, thanks Julian!
Comment 6 Frédéric Demians 2016-06-24 05:48:30 UTC
Pushed in 16.05. Will be in 16.05.01.
Comment 7 Julian Maurice 2016-07-01 07:42:48 UTC
Patch pushed to 3.22.x, will be in 3.22.9