Summary: | Translatability: Fix problem with isolated ' in currency.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | I18N/L10N | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | f.demians, hector.hecaxmmx, julian.maurice, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 16701: Translatability: Fix problem with isolated ' in currency.tt
Bug 16701: (follow-up) improve some changes [SIGNED-OFF]Bug 16701: Translatability: Fix problem with isolated ' in currency.tt Bug 16701: (follow-up) improve some changes Bug 16701: (follow-up) improve some changes [PASSED QA] Bug 16701: Translatability: Fix problem with isolated ' in currency.tt [PASSED QA] Bug 16701: (follow-up) improve some changes |
Description
Marc Véron
2016-06-09 14:59:58 UTC
Could be done with technique as proposed by K.Hall in Bug 15707. See comment: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707#c75 ...and following Created attachment 52635 [details] [review] Bug 16701: Translatability: Fix problem with isolated ' in currency.tt This patch moves markup <span class="ex"> into template variables to avoid sentence splitting. To test: - Apply patch - Verify that currency administration works as before (Home > Administration > Currencies & Exchange rates > Currencies) - Examine code changes Created attachment 53178 [details] [review] Bug 16701: (follow-up) improve some changes Add missing quote in line 152 Modify title of the page and breadcrumbs section wrong "searchfield" used should be instead "currency.currency" To test -Try to delete the active and used currency, for example, my case USD, look that appear USD' with the initial single quote missing in message Confirm deletion of currency USD' -Notice about the breadcrumbs section appear: Confirm deletion of currency '' Should appear the currency -Try to delete another currency see the pharese look the same -Notice about the title in both cases, there is missing the currency name -Apply follow-up and re-test Created attachment 53179 [details] [review] [SIGNED-OFF]Bug 16701: Translatability: Fix problem with isolated ' in currency.tt This patch moves markup <span class="ex"> into template variables to avoid sentence splitting. To test: - Apply patch - Verify that currency administration works as before (Home > Administration > Currencies & Exchange rates > Currencies) - Examine code changes Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Hi Marc Please, test the follow-up and sign-off :) Regards Created attachment 53180 [details] [review] Bug 16701: (follow-up) improve some changes Add missing quote in line 152 Modify title of the page and breadcrumbs section wrong "searchfield" used should be instead "currency.currency" To test -Try to delete the active and used currency, for example, my case USD, look that appear USD' with the initial single quote missing in message Confirm deletion of currency USD' -Notice about the breadcrumbs section appear: Confirm deletion of currency '' Should appear the currency -Try to delete another currency see the pharese look the same -Notice about the title in both cases, there is missing the currency name -Apply follow-up and re-test Created attachment 53253 [details] [review] Bug 16701: (follow-up) improve some changes Add missing quote in line 152 Modify title of the page and breadcrumbs section wrong "searchfield" used should be instead "currency.currency" To test -Try to delete the active and used currency, for example, my case USD, look that appear USD' with the initial single quote missing in message Confirm deletion of currency USD' -Notice about the breadcrumbs section appear: Confirm deletion of currency '' Should appear the currency -Try to delete another currency see the pharese look the same -Notice about the title in both cases, there is missing the currency name -Apply follow-up and re-test Sing-off on followup Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 53283 [details] [review] [PASSED QA] Bug 16701: Translatability: Fix problem with isolated ' in currency.tt This patch moves markup <span class="ex"> into template variables to avoid sentence splitting. To test: - Apply patch - Verify that currency administration works as before (Home > Administration > Currencies & Exchange rates > Currencies) - Examine code changes Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 53284 [details] [review] [PASSED QA] Bug 16701: (follow-up) improve some changes Add missing quote in line 152 Modify title of the page and breadcrumbs section wrong "searchfield" used should be instead "currency.currency" To test -Try to delete the active and used currency, for example, my case USD, look that appear USD' with the initial single quote missing in message Confirm deletion of currency USD' -Notice about the breadcrumbs section appear: Confirm deletion of currency '' Should appear the currency -Try to delete another currency see the pharese look the same -Notice about the title in both cases, there is missing the currency name -Apply follow-up and re-test Sing-off on followup Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 16.11, thanks Marc! Pushed in 16.05. Will be in 16.05.02. Patches pushed to 3.22.x, will be in 3.22.10 |