Description
duy tinh
2016-06-10 10:05:40 UTC
Created attachment 52221 [details] [review] Bug 16705 - Add missing status The bug is related to 10851. Due to add of status in 10851, status added were missing in opac-detail.tt and opac-full-serial-issues.tt. The patch just added these missing status. To test: 1) Create New subscription in Serials, in Intranet 2) Do a search of the new subscription by Title 3) Take Serial receive as Actions to edit the status to Missing (<something>) 4) Go to Opac and Search the subscription created, by its title and See missing status 5) Apply patch, status must be showed. 6) Sign off Comment on attachment 52221 [details] [review] Bug 16705 - Add missing status The bug is related to 10851. Due to add of status in 10851, status added were missing in opac-detail.tt and opac-full-serial-issues.tt. The patch just added these missing status. >From c5905e53f8b11af13743dce1ad88c89c2f09ba93 Mon Sep 17 00:00:00 2001 >From: NguyenDuyTinh <duy-tinh.nguyen@biblibre.com> >Date: Fri, 10 Jun 2016 10:14:12 +0000 >Subject: [NEED SIGN OFF] Bug 16705 - Add missing status > The bug is related to 10851. > Due to add of status in 10851, status added were missing in opac-detail.tt > and opac-full-serial-issues.tt. The patch just added these missing status. > >To test: >1) Create New subscription in Serials, in Intranet >2) Do a search of the new subscription by Title >3) Take Serial receive as Actions to edit the status to Missing (<something>) >4) Go to Opac and Search the subscription created, by its title and See missing status >5) Apply patch, status must be showed. >6) Sign off >--- > .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 31 +++++++++------------- > .../en/modules/opac-full-serial-issues.tt | 4 +++ > 2 files changed, 16 insertions(+), 19 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index fe72d01..fe8e606 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -832,25 +832,18 @@ > <td>[% latestserial.serialseq %]</td> > <td>[% latestserial.planneddate %]</td> > <td> >- [% IF ( latestserial.status1 ) %] >- Awaited >- [% ELSE %] >- [% IF ( latestserial.status2 ) %] >- Arrived >- [% ELSE %] >- [% IF ( latestserial.status3 ) %] >- Late >- [% ELSE %] >- [% IF ( latestserial.status4 ) %] >- Missing >- [% ELSE %] >- [% IF ( latestserial.status5 ) %] >- Not issued >- [% END %] >- [% END %] >- [% END %] >- [% END %] >- [% END %] >+ [% IF (latestserial.status1 ) %]Expected[% END %] >+ [% IF (latestserial.status2 ) %]Arrived[% END %] >+ [% IF (latestserial.status3 ) %]Late[% END %] >+ [% IF (latestserial.status4 ) %]Missing[% END %] >+ [% IF (latestserial.status41 ) %]Missing (never received)[% END %] >+ [% IF (latestserial.status42 ) %]Missing (sold out)[% END %] >+ [% IF (latestserial.status43 ) %]Missing (damaged)[% END %] >+ [% IF (latestserial.status44 ) %]Missing (lost)[% END %] >+ [% IF (latestserial.status5 ) %]Not issued[% END %] >+ [% IF (latestserial.status6 ) %]Delete[% END %] >+ [% IF (latestserial.status7 ) %]Claimed[% END %] >+ [% IF (latestserial.status8 ) %]Stopped[% END %] > </td> > <td>[% latestserial.notes %]</td> > </tr> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt >index dbe1e11..e633dd3 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt >@@ -112,6 +112,10 @@ > [% IF ( serial.status2 ) %]Arrived[% END %] > [% IF ( serial.status3 ) %]Late[% END %] > [% IF ( serial.status4 ) %]Missing[% END %] >+ [% IF ( serial.status41 ) %]Missing (never received)[% END %] >+ [% IF ( serial.status42 ) %]Missing (sold out)[% END %] >+ [% IF ( serial.status43 ) %]Missing (damaged)[% END %] >+ [% IF ( serial.status44 ) %]Missing (lost)[% END %] > [% IF ( serial.status5 ) %]Not available[% END %] > [% IF ( serial.status6 ) %]Delete[% END %] > [% IF ( serial.status7 ) %]Claimed[% END %] >-- >2.7.4 Created attachment 52442 [details] [review] Bug 16705 - Add missing status The bug is related to 10851. Due to add of status in 10851, status added were missing in opac-detail.tt and opac-full-serial-issues.tt. The patch just added these missing status. To test: 1) Create New subscription in Serials, in Intranet 2) Do a search of the new subscription by Title 3) Take Serial receive as Actions to edit the status to Missing (<something>) 4) Go to Opac and Search the subscription created, by its title and See missing status 5) Apply patch, status must be showed. 6) Sign off Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 52443 [details] [review] Bug 16705 - Add missing status to serials history in OPAC The bug is related to 10851. Due to add of status in 10851, status added were missing in opac-detail.tt and opac-full-serial-issues.tt. The patch just added these missing status. To test: 1) Create New subscription in Serials, in Intranet 2) Do a search of the new subscription by Title 3) Take Serial receive as Actions to edit the status to Missing (<something>) 4) Go to Opac and Search the subscription created, by its title and See missing status 5) Apply patch, status must be showed. 6) Sign off Followed test plan, works as expected. Amended to format commit title and message. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 52545 [details] [review] [PASSED QA] Bug 16705 - Add missing status to serials history in OPAC The bug is related to 10851. Due to add of status in 10851, status added were missing in opac-detail.tt and opac-full-serial-issues.tt. The patch just added these missing status. To test: 1) Create New subscription in Serials, in Intranet 2) Do a search of the new subscription by Title 3) Take Serial receive as Actions to edit the status to Missing (<something>) 4) Go to Opac and Search the subscription created, by its title and See missing status 5) Apply patch, status must be showed. 6) Sign off Followed test plan, works as expected. Amended to format commit title and message. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for Koha 16.11, thanks Duy Tinh! Pushed in 16.05. Will be in 16.05.02. Patches pushed to 3.22.x, will be in 3.22.10 |