Summary: | Invalid SQL GROUP BY clauses in GetborCatFromCatType and GetAuthorisedValues | ||
---|---|---|---|
Product: | Koha | Reporter: | Srdjan Jankovic <srdjan> |
Component: | Architecture, internals, and plumbing | Assignee: | Srdjan Jankovic <srdjan> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | f.demians, jonathan.druart, julian.maurice, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 16716: Replaced wrong GROUP BY with DISTINCT
Bug 16716: Replaced wrong GROUP BY with DISTINCT Bug 16716: Replaced wrong GROUP BY with DISTINCT |
Description
Srdjan Jankovic
2016-06-13 03:30:31 UTC
MySQL used to tolerate it, but won't any more. A noop, places where GetborCatFromCatType() (member area, eg add/modify member) and GetAuthorisedValues() (all over the place, eg item edit for Lost status etc) are used. Created attachment 52297 [details] [review] Bug 16716: Replaced wrong GROUP BY with DISTINCT A quick comment to tell that bug 15407 is going to remove GetborCatFromCatType Ok, I can either drop that one now or wait for 15407 to be merged. The thing is anyone installing on a newer version of MySql may find this a quick fix. What about the authorised values? (In reply to Srdjan Jankovic from comment #4) > Ok, I can either drop that one now or wait for 15407 to be merged. The thing > is anyone installing on a newer version of MySql may find this a quick fix. > What about the authorised values? I think you are right. It should be pushed before bug 15407 or at least a version for 16.05 will have to be provided. The AV change looks good to me. Waiting for QAing it! Created attachment 53567 [details] [review] Bug 16716: Replaced wrong GROUP BY with DISTINCT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: prove t/db_dependent/Koha.t triggers auth function. Created attachment 53600 [details] [review] Bug 16716: Replaced wrong GROUP BY with DISTINCT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 16.11, thanks Srdjan! Pushed in 16.05. Will be in 16.05.02. Patches pushed to 3.22.x, will be in 3.22.10 |