Summary: | DBIx ActionLogs.pm should be removed | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, f.demians, julian.maurice, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 16720: Remove DBIx ActionLogs.pm
[SIGNED-OFF] Bug 16720: Remove DBIx ActionLogs.pm Bug 16720: Remove DBIx ActionLogs.pm |
Description
Tomás Cohen Arazi (tcohen)
2016-06-13 16:04:00 UTC
Created attachment 52322 [details] [review] Bug 16720: Remove DBIx ActionLogs.pm The update_dbix_class_files.pl script generates ActionLog.pm instead, which is already on the source tree. To test: - Apply the patch => SUCCESS: Koha/Schema/Result/ActionLogs.pm is removed - Run: $ mysql -uroot > CREATE DATABASE dbic; \q $ mysql -uroot dbic < kohaclone/installer/data/mysql/kohastructure.sql $ misc/devel/update_dbix_class_files.pl --db_name dbic --db_user root => SUCCESS: Koha/Schema/Result/ActionLogs.pm is not re-generated - Run: $ git grep ActionLogs => SUCCESS: There's no code using it - Sign off Created attachment 52345 [details] [review] [SIGNED-OFF] Bug 16720: Remove DBIx ActionLogs.pm The update_dbix_class_files.pl script generates ActionLog.pm instead, which is already on the source tree. To test: - Apply the patch => SUCCESS: Koha/Schema/Result/ActionLogs.pm is removed - Run: $ mysql -uroot > CREATE DATABASE dbic; \q $ mysql -uroot dbic < kohaclone/installer/data/mysql/kohastructure.sql $ misc/devel/update_dbix_class_files.pl --db_name dbic --db_user root => SUCCESS: Koha/Schema/Result/ActionLogs.pm is not re-generated - Run: $ git grep ActionLogs => SUCCESS: There's no code using it - Sign off Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Just for the record, I confirmed this is the only schema file in this situation. Created attachment 52394 [details] [review] Bug 16720: Remove DBIx ActionLogs.pm The update_dbix_class_files.pl script generates ActionLog.pm instead, which is already on the source tree. To test: - Apply the patch => SUCCESS: Koha/Schema/Result/ActionLogs.pm is removed - Run: $ mysql -uroot > CREATE DATABASE dbic; \q $ mysql -uroot dbic < kohaclone/installer/data/mysql/kohastructure.sql $ misc/devel/update_dbix_class_files.pl --db_name dbic --db_user root => SUCCESS: Koha/Schema/Result/ActionLogs.pm is not re-generated - Run: $ git grep ActionLogs => SUCCESS: There's no code using it - Sign off Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master, thanks Tomas! Pushed in 16.05. Will be in 16.05.01. Patch pushed to 3.22.x, will be in 3.22.9 Pushed to 3.20.x will be in 3.20.13 |