Bug 16727

Summary: Upload tool needs better warning
Product: Koha Reporter: Nicole C. Engard <nengard>
Component: ToolsAssignee: Nicole C. Engard <nengard>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: minor    
Priority: P5 - low CC: brendan, f.demians, julian.maurice, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 16727: Clarify upload category note
[SIGNED-OFF] Bug 16727: Clarify upload category note
Bug 16727: Clarify upload category note

Description Nicole C. Engard 2016-06-13 18:01:02 UTC
If you don't have an UPLOAD authorized value category set the upload tool says 

"Note: No upload categories have been defined. All uploads will be marked as temporary." 

But doesn't say that you have to create an authorized value. The error should be clearer.
Comment 1 Nicole C. Engard 2016-07-27 13:29:57 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2016-07-27 13:55:41 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2016-07-27 14:28:57 UTC
Created attachment 53754 [details] [review]
Bug 16727: Clarify upload category note

This patch clarifies the note on the upload tool
that states that no categories are defined.

To test:

* Log in to Koha
* Confirm that you have no values set for the UPLOAD
  authorized value category
* Visit Tools > Upload
* Check the warning note for typos
* Add a authorized value category for UPLOAD
* Visit Tools > Upload
* Confirm that note is replaced

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Brendan Gallagher 2016-08-04 21:31:36 UTC
pushed to master - Should be in the November 2016 release.  Thanks!
Comment 5 Frédéric Demians 2016-08-05 06:56:54 UTC
Pushed in 16.05. Will be in 16.05.03.
Comment 6 Julian Maurice 2016-08-17 13:44:58 UTC
Patch pushed to 3.22.x, will be in 3.22.10