Bug 16741

Summary: Remove dead code "sub itemissues" from C4/Circulation.pm
Product: Koha Reporter: Marc Véron <veron>
Component: Architecture, internals, and plumbingAssignee: Marc Véron <veron>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: f.demians, kyle
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 16741 - Remove dead code "sub itemissues" from C4/Circulation.pm
Bug 16741 - Remove dead code "sub itemissues" from C4/Circulation.pm
Bug 16741 - Remove dead code "sub itemissues" from C4/Circulation.pm

Description Marc Véron 2016-06-15 06:05:18 UTC
It seems that sub itemissues, defined in C4/Circulation.pm, is never used.

Behalve of C4/Circulation.pm it is only found (but not used) in:
catalogue/moredetail.pl:use C4::Circulation;  # to use itemissues

To verify:
- git grep itemissues
- comment out line 33 in catalogue/moredetail.pl, verifiy that 
  there are no errors or side effects
Comment 1 Marc Véron 2016-08-10 08:18:29 UTC Comment hidden (obsolete)
Comment 2 Claire Gravely 2016-08-11 08:41:45 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-08-11 09:41:04 UTC
Created attachment 54289 [details] [review]
Bug 16741 - Remove dead code "sub itemissues" from C4/Circulation.pm

To verify:
- git grep itemissues
Result: Appears in C4/Circulation.pm only

To test:
- apply patch
- git grep itemissues
Expected result: No occurences
- prove t/db_dependent/Circulation.t
Expected result: Pass OK

Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Kyle M Hall (khall) 2016-08-18 16:17:16 UTC
Pushed to master for 16.11, thanks Marc!
Comment 5 Frédéric Demians 2016-08-23 10:47:38 UTC
Pushed in 16.05. Will be in 16.05.03.