Summary: | Fix regression in patron card creator (patron image) | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | Label/patron card printing | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | critical | ||
Priority: | P5 - low | CC: | brendan, f.demians, josef.moravec, julian.maurice |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 15635 | ||
Bug Blocks: | |||
Attachments: |
Bug 16747 - Patron card creator broken with version 16.05
[SIGNED-OFF] Bug 16747 - Patron card creator broken with version 16.05 Bug 16747 - Patron card creator broken with version 16.05 |
Description
Marc Véron
2016-06-15 20:52:21 UTC
Bug seems to be related to Bug 15635 - Move the patron images related code to Koha::Patron::Images Found, patch follows. Created attachment 52454 [details] [review] Bug 16747 - Patron card creator broken with version 16.05 To reproduce: - Prepare a patron car layout with Image 1 using Patron Image - Create a patron card for a patron without patron image Result: OK, PDF can be opened wit PDF viewer - Try to create a patron card with a patron who has a patron image Result: The PDF file is corrupt (contains text only with error message) intranet error log contains: create-pdf.pl: Illegal division by zero at /usr/share/kohaclone/patroncards/create-pdf.pl line 200 To test: - Apply patch - Create a patron card with a patron who has a patron image Result: PDF is OK and contains the image Bonus test: Do the same with a card layout with an additional image (Image 2: Image source: Other image) Created attachment 52481 [details] [review] [SIGNED-OFF] Bug 16747 - Patron card creator broken with version 16.05 To reproduce: - Prepare a patron car layout with Image 1 using Patron Image - Create a patron card for a patron without patron image Result: OK, PDF can be opened wit PDF viewer - Try to create a patron card with a patron who has a patron image Result: The PDF file is corrupt (contains text only with error message) intranet error log contains: create-pdf.pl: Illegal division by zero at /usr/share/kohaclone/patroncards/create-pdf.pl line 200 To test: - Apply patch - Create a patron card with a patron who has a patron image Result: PDF is OK and contains the image Bonus test: Do the same with a card layout with an additional image (Image 2: Image source: Other image) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Test and bonus test pass: PDF generated without errors. Created attachment 52483 [details] [review] Bug 16747 - Patron card creator broken with version 16.05 To reproduce: - Prepare a patron car layout with Image 1 using Patron Image - Create a patron card for a patron without patron image Result: OK, PDF can be opened wit PDF viewer - Try to create a patron card with a patron who has a patron image Result: The PDF file is corrupt (contains text only with error message) intranet error log contains: create-pdf.pl: Illegal division by zero at /usr/share/kohaclone/patroncards/create-pdf.pl line 200 To test: - Apply patch - Create a patron card with a patron who has a patron image Result: PDF is OK and contains the image Bonus test: Do the same with a card layout with an additional image (Image 2: Image source: Other image) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Test and bonus test pass: PDF generated without errors. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to Master - Should be in the November 2016 Release. Thanks! Pushed in 16.05. Will be in 16.05.01. Not needed in 3.22.x |