Description
Agnes Rivers-Moore
2016-06-15 22:23:28 UTC
Yes, it would be great to have a way to specify the due date for batch checkout. Yes, as it happens all our batch issues require a specific date. Some of our customers are using this Batch Checkout feature but would really like to be able to specify a due date. This would be a really good enhancement. This would be such a helpful feature for us! Mass issuing of orchestral sets for after performance dates has been great via batchcheck-out, but having to go back in to renew to a different date is a faff. Would be great to see this development! Would like to request this enhancement also. *** Bug 16113 has been marked as a duplicate of this bug. *** +1 With COVID, returned items are being sent to quarantine, and this enhancement is suddenly more urgent. We use batch checkout to rapidly check in items from the borrower, and out to a Quarantine "patron", while bypassing all holds or other prompts. The quarantine period is different for some items than normal, may be longer if returning from a long term care home, shorter if they were in the drop box for a day already. Hoping someone will consider working on this soon. Created attachment 107781 [details] [review] Bug 16748: Add the ability to define due date in batch checkout This patch allows the librarian to pick the due date when batch checkout Test plan: Batch checkout using a hard due date => Notice that the due date is taken into account Batch checkout the same barcodes with a different due date, to trigger the confirmation step => Notice that the due date is taken into account for the renewals Created attachment 107782 [details] [review] Bug 16748: Add the ability to define due date in batch checkout This patch allows the librarian to pick the due date when batch checkout Test plan: Batch checkout using a hard due date => Notice that the due date is taken into account Batch checkout the same barcodes with a different due date, to trigger the confirmation step => Notice that the due date is taken into account for the renewals Created attachment 107783 [details] [review] Bug 16748: Add the ability to define due date in batch checkout This patch allows the librarian to pick the due date when batch checkout Test plan: Batch checkout using a hard due date => Notice that the due date is taken into account Batch checkout the same barcodes with a different due date, to trigger the confirmation step => Notice that the due date is taken into account for the renewals Created attachment 107785 [details] [review] Bug 16748: Add the ability to define due date in batch checkout This patch allows the librarian to pick the due date when batch checkout Test plan: Batch checkout using a hard due date => Notice that the due date is taken into account Batch checkout the same barcodes with a different due date, to trigger the confirmation step => Notice that the due date is taken into account for the renewals I've tried testing this patch using a sandbox but I can't see the due date picker on the batch checkout screen. I'm new to the sandbox so it's possible I've made a mistake applying the patch. The patch doesn't add a due date picker to batch checkout. Instead it adds one to the batch renew page. Is this a copy and paste issue from the very similar patch for for bug 16112? Created attachment 107863 [details] [review] Bug 16748: Add the ability to define due date in batch checkout This patch allows the librarian to pick the due date when batch checkout Test plan: Batch checkout using a hard due date => Notice that the due date is taken into account Batch checkout the same barcodes with a different due date, to trigger the confirmation step => Notice that the due date is taken into account for the renewals Created attachment 107864 [details] [review] Bug 16748: Add the ability to define due date in batch checkout This patch allows the librarian to pick the due date when batch checkout Test plan: Batch checkout using a hard due date => Notice that the due date is taken into account Batch checkout the same barcodes with a different due date, to trigger the confirmation step => Notice that the due date is taken into account for the renewals I introduced a last minute change that broke the patch. It should work correctly now. Created attachment 108079 [details] [review] Bug 16748: Add the ability to define due date in batch checkout This patch allows the librarian to pick the due date when batch checkout Test plan: Batch checkout using a hard due date => Notice that the due date is taken into account Batch checkout the same barcodes with a different due date, to trigger the confirmation step => Notice that the due date is taken into account for the renewals Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Thanks Jonathan, I was able to set a due date for batch checkout and can confirm that the due date set applies for any items renewed as well. Is that what you mean by a 'hard due date'? I wasn't sure why the label says 'hard due date' rather than 'Specify due date'. Hi Henry, thanks for testing! I used "Hard due date" because it's what we use in the "Batch extend due dates" tool. I also used this term on bug 16112. I can modify it if you think it's confusing. Created attachment 108344 [details] [review] Bug 16748: Add the ability to define due date in batch checkout This patch allows the librarian to pick the due date when batch checkout Test plan: Batch checkout using a hard due date => Notice that the due date is taken into account Batch checkout the same barcodes with a different due date, to trigger the confirmation step => Notice that the due date is taken into account for the renewals Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> The GUI could be improved a bit, but overall this is a nice clean patch for a long-wanted functionality :) (In reply to Katrin Fischer from comment #22) > The GUI could be improved a bit What do you suggest? Overall it's not our best of GUIs - the labels wrap on multiple lines. I was thinking maybe it would be nice to keep the label short and a hint below of after the fields. (In reply to Katrin Fischer from comment #24) > Overall it's not our best of GUIs I agree. Not the fault of the patch of course, but the page could use improvement. I thought the same thing while testing this patch. Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |