| Summary: | OPAC suggestions, existing suggestions don't show after placing a suggestion | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Acquisitions | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED WORKSFORME | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | cunha, nick, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: | Bug 16767 - OPAC suggestions, existing suggestions don't show after placing a suggestion | ||
Created attachment 52503 [details] [review] Bug 16767 - OPAC suggestions, existing suggestions don't show after placing a suggestion To test: 1 - Before applying this patch, place some suggestions 2 - Note that on success you see no suggestions 3 - Apply this patch 4 - Add a suggestion, note you see the new suggestion and all other 5 - Add a duplicate suggestion, note suggestions is rejected and you see all existing Needs to be unit tested Works fine. QA tool complains about a forbidden pattern tab char, opac/opac-suggestions.pl (line 136) Nick, did you forget about this one? :) Seems to be fixed |
After placing a purchase suggestion on the opac the confirmation screen reads: "Your suggestion has been submitted. There are no pending purchase suggestions." Place another, same result. These lines in opac-suggestions.pl don't seem to be working as intended: 136 ^I^I$$suggestion{$_}='' foreach qw<title author publishercode copyrightdate place collectiontitle isbn STATUS>; 137 ^I^I$suggestions_loop = 138 ^I^I &SearchSuggestion( $suggestion );