Summary: | Koha::Cache->set_in_cache calls need to be standardised | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | brendan, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 16769: Uniformise calls to Koha::Cache->set_in_cache
Bug 16769: Uniformise calls to Koha::Cache->set_in_cache Bug 16769: [QA Follow-up] Still found an occurrence Bug 16769: [QA Follow-up] Remove unsupported deepcopy parameter Bug 16769: Uniformise calls to Koha::Cache->set_in_cache Bug 16769: [QA Follow-up] Still found an occurrence Bug 16769: [QA Follow-up] Remove unsupported deepcopy parameter |
Description
Jonathan Druart
2016-06-18 14:04:00 UTC
Created attachment 52512 [details] [review] Bug 16769: Uniformise calls to Koha::Cache->set_in_cache From the POD of Koha::Cache->set_in_cache: # This is a bit of a hack to support the old API in case things still use it Let's remove this hack and update old calls. Test plan: Look at the results of git grep set_in_cache and confirm that there are no more version of the old call (without hashref as third param) Created attachment 53751 [details] [review] Bug 16769: Uniformise calls to Koha::Cache->set_in_cache From the POD of Koha::Cache->set_in_cache: # This is a bit of a hack to support the old API in case things still use it Let's remove this hack and update old calls. Test plan: Look at the results of git grep set_in_cache and confirm that there are no more version of the old call (without hashref as third param) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 53752 [details] [review] Bug 16769: [QA Follow-up] Still found an occurrence Script svc/report did contain one old-style call. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 53753 [details] [review] Bug 16769: [QA Follow-up] Remove unsupported deepcopy parameter Routine C4/Koha/GetAuthorisedValues adds deepcopy => 1 to the options of set_in_cache. This makes no sense (anymore?). Is not supported or passed further. So better remove it. Test plan: Run t/db_dependent/Koha.t (with Test::Deep available to minimize confusion) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 56013 [details] [review] Bug 16769: Uniformise calls to Koha::Cache->set_in_cache From the POD of Koha::Cache->set_in_cache: # This is a bit of a hack to support the old API in case things still use it Let's remove this hack and update old calls. Test plan: Look at the results of git grep set_in_cache and confirm that there are no more version of the old call (without hashref as third param) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 56014 [details] [review] Bug 16769: [QA Follow-up] Still found an occurrence Script svc/report did contain one old-style call. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 56015 [details] [review] Bug 16769: [QA Follow-up] Remove unsupported deepcopy parameter Routine C4/Koha/GetAuthorisedValues adds deepcopy => 1 to the options of set_in_cache. This makes no sense (anymore?). Is not supported or passed further. So better remove it. Test plan: Run t/db_dependent/Koha.t (with Test::Deep available to minimize confusion) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to Master - Should be in the november 16.11 release. Thanks! |