Summary: | Use Font Awesome for arrows instead of images in audio_alerts.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Héctor Eduardo Castro Avalos <hector.hecaxmmx> |
Component: | Templates | Assignee: | Héctor Eduardo Castro Avalos <hector.hecaxmmx> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | f.demians, julian.maurice, kyle, oleonard, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 16148 | ||
Bug Blocks: | |||
Attachments: |
Bug 16793: Use Font Awesome for arrows instead of images in audio_alerts.tt
Bug 16793: Use Font Awesome for arrows instead of images in audio_alerts.tt Bug 16793: Use Font Awesome for arrows instead of images in audio_alerts.tt Bug 16793 [16.05] Add 3 missing css rules |
Description
Héctor Eduardo Castro Avalos
2016-06-21 21:15:41 UTC
Created attachment 52673 [details] [review] Bug 16793: Use Font Awesome for arrows instead of images in audio_alerts.tt This changes fit with bug 16148 for marc modification template management To test -Apply patch -Goto Admin->Audio alerts -Verify that green arrows have disappeared now in blue Awesome Icons Created attachment 52675 [details] [review] Bug 16793: Use Font Awesome for arrows instead of images in audio_alerts.tt This changes fit with bug 16148 for marc modification template management To test -Apply patch -Goto Admin->Audio alerts -Verify that green arrows have disappeared now in blue Awesome Icons Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 52823 [details] [review] Bug 16793: Use Font Awesome for arrows instead of images in audio_alerts.tt This changes fit with bug 16148 for marc modification template management To test -Apply patch -Goto Admin->Audio alerts -Verify that green arrows have disappeared now in blue Awesome Icons Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=16794 Pushed to master for 16.11, thanks Hector! Pushed in 16.05. Will be in 16.05.02. Frédéric, some style definitions may be missing in 16.05 (.overline, .underline, .order-control) since they are introduced by bug 16148, which is not in 16.05.x (In reply to Julian Maurice from comment #6) > Frédéric, some style definitions may be missing in 16.05 (.overline, > .underline, .order-control) since they are introduced by bug 16148, which is > not in 16.05.x Thanks a lot for catching this! You're totally correct. Those CSS rules are missing in 16.05.x. The visual effect is almost unnoticeable, but it's there. I will fix that. Thks again. Created attachment 54513 [details] [review] Bug 16793 [16.05] Add 3 missing css rules |