| Summary: | Patron categories: Crash if enrolment date is not valid | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marc Véron <veron> |
| Component: | Architecture, internals, and plumbing | Assignee: | Galen Charlton <gmcharlt> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16612 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 14060 | ||
| Bug Blocks: | |||
| Attachments: | Bug 16976 - Authorities searches with double quotes gives ZOOM error 20003 [Alternate] | ||
Still valid. Created attachment 64381 [details] [review] Bug 16976 - Authorities searches with double quotes gives ZOOM error 20003 [Alternate] I dug into this a little bit, it seems the issue is that we were double processing the query because of an extra call to C4::AuthoritiesMarc::SearchAuthorities I think we can simply remove this call To test: 1 - Perform an authority search for a value that returns results 2 - Wrap it in quotes and search 3 - 'Internal server error' 4 - Apply patch 5 - Search with quotes succeeds I've tried, but I always get told my date is invalid :) |
To reproduce: - Create or edit a patron category - Leve enrolment period empty - Manually enter wrong enrolment date, e.g. 99/99/2016 and save. Result: Software error: The 'day' parameter ("99") to DateTime::new did not pass the 'an integer which is a possible valid day of month' callback at /usr/lib/perl5/DateTime.pm line 199 DateTime::new(undef, 'hour', 0, 'minute', 0, 'second', 0, 'month', 06, ...) called at /usr/share/kohaclone/Koha/DateUtils.pm line 172 Koha::DateUtils::dt_from_string(99.06.2016) called at /usr/share/kohaclone/admin/categories.pl line 98