Summary: | "Too soon" renewal error generates no alert for user | ||
---|---|---|---|
Product: | Koha | Reporter: | Eric Phetteplace <ephetteplace> |
Component: | OPAC | Assignee: | Eric Phetteplace <ephetteplace> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | ephetteplace, f.demians, julian.maurice, kyle |
Version: | 16.05 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
example of error
patch for opac-user.tt Bug 16806: no error message for 'too_soon' renewal Bug 16806: no error message for 'too_soon' renewal [PASSED QA] Bug 16806: no error message for 'too_soon' renewal |
Description
Eric Phetteplace
2016-06-23 23:01:12 UTC
Created attachment 52774 [details] [review] patch for opac-user.tt Created attachment 54085 [details] [review] Bug 16806: no error message for 'too_soon' renewal To test: - for a particular item type & patron category, configure a non-zero "no renewal before" date so items can't be immediately renewed - sign in as a patron in aforementioned patron category - check out an item of aforementioned item type - go to your renewals page in OPAC /cgi-bin/koha/opac-user.pl - an error messages appears in the div.alert.dialog up top Sponsored-by: California College of the Arts Signed-off-by: Brendon Ford <brendon.ford@manhattan.edu> Created attachment 54087 [details] [review] Bug 16806: no error message for 'too_soon' renewal To test: - for a particular item type & patron category, configure a non-zero "no renewal before" date so items can't be immediately renewed - sign in as a patron in aforementioned patron category - check out an item of aforementioned item type - go to your renewals page in OPAC /cgi-bin/koha/opac-user.pl - an error messages appears in the div.alert.dialog up top Sponsored-by: California College of the Arts Signed-off-by: Brendon Ford <brendon.ford@manhattan.edu> Signed-off-by: Irma Birchall <irma@calyx.net.au> Created attachment 54116 [details] [review] [PASSED QA] Bug 16806: no error message for 'too_soon' renewal To test: - for a particular item type & patron category, configure a non-zero "no renewal before" date so items can't be immediately renewed - sign in as a patron in aforementioned patron category - check out an item of aforementioned item type - go to your renewals page in OPAC /cgi-bin/koha/opac-user.pl - an error messages appears in the div.alert.dialog up top Sponsored-by: California College of the Arts Signed-off-by: Brendon Ford <brendon.ford@manhattan.edu> Signed-off-by: Irma Birchall <irma@calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thx Eric, Brendon and Irma! Pushed to master for 16.11, thanks Eric! Pushed in 16.05. Will be in 16.05.03. Pushed to 3.22.x, will be in 3.22.10 |