Summary: | Frameworks unordered in dropdown when adding/editing a biblio | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens <nick> |
Component: | Cataloging | Assignee: | Nick Clemens <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | barton, f.demians, hector.hecaxmmx, jonathan.druart, julian.maurice, kyle, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 14889 | ||
Bug Blocks: | |||
Attachments: |
Bug 16807 - Frameworks unordered in dropdown when adding/editing a biblio
[SIGNED-OFF]Bug 16807: Frameworks unordered in dropdown when adding/editing a biblio Bug 16807 - Use Koha::BiblioFrameworks instead of GetFrameWorkLoop Bug 16807: Frameworks unordered in dropdown when adding/editing a biblio Bug 16807 - Use Koha::BiblioFrameworks instead of GetFrameWorkLoop |
Description
Nick Clemens
2016-06-24 13:56:57 UTC
Created attachment 52799 [details] [review] Bug 16807 - Frameworks unordered in dropdown when adding/editing a biblio To test: Start to add or edit a biblio Open the dropdown to change framework Notice the order Refresh the page - notice the order changes Apply patch Order is alphabetical Refresh the page Order does not change Created attachment 52808 [details] [review] [SIGNED-OFF]Bug 16807: Frameworks unordered in dropdown when adding/editing a biblio To test: Start to add or edit a biblio Open the dropdown to change framework Notice the order Refresh the page - notice the order changes Apply patch Order is alphabetical Refresh the page Order does not change Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described I removes GetFrameWorksLoop in bug 15801 (needs QA), could you please avoid to introduce a new call to it? s/removes/removed Created attachment 52828 [details] [review] Bug 16807 - Use Koha::BiblioFrameworks instead of GetFrameWorkLoop Refactor code to use work from 14889 Created attachment 52833 [details] [review] Bug 16807: Frameworks unordered in dropdown when adding/editing a biblio To test: Start to add or edit a biblio Open the dropdown to change framework Notice the order Refresh the page - notice the order changes Apply patch Order is alphabetical Refresh the page Order does not change Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 52834 [details] [review] Bug 16807 - Use Koha::BiblioFrameworks instead of GetFrameWorkLoop Refactor code to use work from 14889 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 16.11, thanks Nick! Can this be back-ported? It looks like a fairly small patch. Pushed in 16.05. Will be in 16.05.02. |