Bug 16807

Summary: Frameworks unordered in dropdown when adding/editing a biblio
Product: Koha Reporter: Nick Clemens <nick>
Component: CatalogingAssignee: Nick Clemens <nick>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: barton, f.demians, hector.hecaxmmx, jonathan.druart, julian.maurice, kyle, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 14889    
Bug Blocks:    
Attachments: Bug 16807 - Frameworks unordered in dropdown when adding/editing a biblio
[SIGNED-OFF]Bug 16807: Frameworks unordered in dropdown when adding/editing a biblio
Bug 16807 - Use Koha::BiblioFrameworks instead of GetFrameWorkLoop
Bug 16807: Frameworks unordered in dropdown when adding/editing a biblio
Bug 16807 - Use Koha::BiblioFrameworks instead of GetFrameWorkLoop

Description Nick Clemens 2016-06-24 13:56:57 UTC
addbiblio.pl  should use GetFrameWorksLoop instead of getframeworks
Comment 1 Nick Clemens 2016-06-24 14:01:15 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-06-24 14:53:22 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-06-24 15:35:28 UTC
I removes GetFrameWorksLoop in bug 15801 (needs QA), could you please avoid to introduce a new call to it?
Comment 4 Jonathan Druart 2016-06-24 15:35:40 UTC
s/removes/removed
Comment 5 Nick Clemens 2016-06-24 16:06:17 UTC Comment hidden (obsolete)
Comment 6 Kyle M Hall 2016-06-24 16:16:11 UTC
Created attachment 52833 [details] [review]
Bug 16807: Frameworks unordered in dropdown when adding/editing a biblio

To test:
Start to add or edit a biblio
Open the dropdown to change framework
Notice the order
Refresh the page - notice the order changes
Apply patch
Order is alphabetical
Refresh the page
Order does not change

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as described

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Kyle M Hall 2016-06-24 16:16:20 UTC
Created attachment 52834 [details] [review]
Bug 16807 - Use Koha::BiblioFrameworks instead of GetFrameWorkLoop

Refactor code to use work from 14889

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 8 Kyle M Hall 2016-07-08 13:06:15 UTC
Pushed to master for 16.11, thanks Nick!
Comment 9 Barton Chittenden 2016-07-12 15:06:17 UTC
Can this be back-ported? It looks like a fairly small patch.
Comment 10 Frédéric Demians 2016-08-01 13:27:02 UTC
Pushed in 16.05. Will be in 16.05.02.