| Summary: | koha-common init.d script should run koha-plack without quiet | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Liz Rea <liz> |
| Component: | Command-line Utilities | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | f.demians, julian.maurice, kyle, m.de.rooy, robin, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: |
Bug 16822: Make koha-common call koha-plack without --quiet
Bug 16822: Make koha-common call koha-plack without --quiet Bug 16822: Make koha-common call koha-plack without --quiet |
||
|
Description
Liz Rea
2016-06-28 00:45:07 UTC
Created attachment 53720 [details] [review] Bug 16822: Make koha-common call koha-plack without --quiet This patch removes the --quiet option switch in koha-common.init so problem information is not hidden for sysadmin users. To test: - Have plack enabled for a koha instance: $ sudo koha-plack --enable kohadev $ sudo koha-plack --start kohadev - Run: $ cd kohaclone $ debian/koha-common.init {start|stop|restart} => SUCCESS: No behaviour change - Disable the 'cgi' apache module: $ sudo a2dismod cgi - Run: $ debian/koha-common.init {start|stop|restart} => FAIL: No warning is shown - Apply the patch - Run: $ debian/koha-common.init {start|stop|restart} => SUCCESS: Warnings show up - Sign off :-D Created attachment 55389 [details] [review] Bug 16822: Make koha-common call koha-plack without --quiet This patch removes the --quiet option switch in koha-common.init so problem information is not hidden for sysadmin users. To test: - Have plack enabled for a koha instance: $ sudo koha-plack --enable kohadev $ sudo koha-plack --start kohadev - Run: $ cd kohaclone $ debian/koha-common.init {start|stop|restart} => SUCCESS: No behaviour change - Disable the 'cgi' apache module: $ sudo a2dismod cgi - Run: $ debian/koha-common.init {start|stop|restart} => FAIL: No warning is shown - Apply the patch - Run: $ debian/koha-common.init {start|stop|restart} => SUCCESS: Warnings show up - Sign off :-D Signed-off-by: Liz Rea <liz@catalyst.net.nz> Perfect thanks :) Created attachment 55395 [details] [review] Bug 16822: Make koha-common call koha-plack without --quiet This patch removes the --quiet option switch in koha-common.init so problem information is not hidden for sysadmin users. To test: - Have plack enabled for a koha instance: $ sudo koha-plack --enable kohadev $ sudo koha-plack --start kohadev - Run: $ cd kohaclone $ debian/koha-common.init {start|stop|restart} => SUCCESS: No behaviour change - Disable the 'cgi' apache module: $ sudo a2dismod cgi - Run: $ debian/koha-common.init {start|stop|restart} => FAIL: No warning is shown - Apply the patch - Run: $ debian/koha-common.init {start|stop|restart} => SUCCESS: Warnings show up - Sign off :-D Signed-off-by: Liz Rea <liz@catalyst.net.nz> Perfect thanks :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 16.11, thanks Tomas! Pushed in 16.05. Will be in 16.05.04. Pushed to 3.22.x, will be in 3.22.11 |