Summary: | Remove C4::Members::GetTitles | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | f.demians, kyle, m.de.rooy, tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 16846 | ||
Attachments: |
Bug 16847: Remove C4::Members::GetTitles
Bug 16847: Add empty option to Salutation/title Bug 16847: Remove C4::Members::GetTitles Bug 16847: Add empty option to Salutation/title Bug 16847: Remove C4::Members::GetTitles Bug 16847: Add empty option to Salutation/title Bug 16847: Remove C4::Members::GetTitles Bug 16847: Add empty option to Salutation/title |
Description
Jonathan Druart
2016-07-04 14:18:08 UTC
Created attachment 53086 [details] [review] Bug 16847: Remove C4::Members::GetTitles This subroutine just reads the content of a pref, split it, add an empty string and returns. It is not really useful and the code in the script (memberentry.pl) uses the only occurrence of CGI::popup_menu Let's remove it and build the dropdown list in the template. Test plan: 1/ Empty BorrowersTitles, edit a patron and confirm that the "Salutation" does not appear 2/ Fill BorrowersTitles with "Mr|Mrs|Miss|Ms", edit a patron and confirm that the "Salutation" dropdown list is correctly filled. The default option should be selected if you are editing a patron with a title defined. This should also be tested at the OPAC. Created attachment 53087 [details] [review] Bug 16847: Add empty option to Salutation/title At the OPAC there is no way to empty this value. I think it should be allowed to empty it. Hi Jonathan. After applying the patches, I get still results for git grep GetTitles: C4/Members.pm: &GetTitles Created attachment 53088 [details] [review] Bug 16847: Remove C4::Members::GetTitles This subroutine just reads the content of a pref, split it, add an empty string and returns. It is not really useful and the code in the script (memberentry.pl) uses the only occurrence of CGI::popup_menu Let's remove it and build the dropdown list in the template. Test plan: 1/ Empty BorrowersTitles, edit a patron and confirm that the "Salutation" does not appear 2/ Fill BorrowersTitles with "Mr|Mrs|Miss|Ms", edit a patron and confirm that the "Salutation" dropdown list is correctly filled. The default option should be selected if you are editing a patron with a title defined. This should also be tested at the OPAC. Created attachment 53089 [details] [review] Bug 16847: Add empty option to Salutation/title At the OPAC there is no way to empty this value. I think it should be allowed to empty it. (In reply to Marc Véron from comment #3) > Hi Jonathan. > > After applying the patches, I get still results for git grep GetTitles: > > C4/Members.pm: &GetTitles Fixed! Thanks for testing Marc! Created attachment 53091 [details] [review] Bug 16847: Remove C4::Members::GetTitles This subroutine just reads the content of a pref, split it, add an empty string and returns. It is not really useful and the code in the script (memberentry.pl) uses the only occurrence of CGI::popup_menu Let's remove it and build the dropdown list in the template. Test plan: 1/ Empty BorrowersTitles, edit a patron and confirm that the "Salutation" does not appear 2/ Fill BorrowersTitles with "Mr|Mrs|Miss|Ms", edit a patron and confirm that the "Salutation" dropdown list is correctly filled. The default option should be selected if you are editing a patron with a title defined. This should also be tested at the OPAC. Followed test pan, works as expected in Staff and OPAC Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 53092 [details] [review] Bug 16847: Add empty option to Salutation/title At the OPAC there is no way to empty this value. I think it should be allowed to empty it. Signed-off-by: Marc Véron <veron@veron.ch> While trying to qa this report, I had a long struggle with report 16591. opac-memberentry hangs on random seed generation (CSRF token) Created attachment 53527 [details] [review] Bug 16847: Remove C4::Members::GetTitles This subroutine just reads the content of a pref, split it, add an empty string and returns. It is not really useful and the code in the script (memberentry.pl) uses the only occurrence of CGI::popup_menu Let's remove it and build the dropdown list in the template. Test plan: 1/ Empty BorrowersTitles, edit a patron and confirm that the "Salutation" does not appear 2/ Fill BorrowersTitles with "Mr|Mrs|Miss|Ms", edit a patron and confirm that the "Salutation" dropdown list is correctly filled. The default option should be selected if you are editing a patron with a title defined. This should also be tested at the OPAC. Followed test pan, works as expected in Staff and OPAC Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 53528 [details] [review] Bug 16847: Add empty option to Salutation/title At the OPAC there is no way to empty this value. I think it should be allowed to empty it. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 16.11, thanks Jonathan! Pushed in 16.05. Will be in 16.05.02. |