Summary: | Remove C4::Members::GetBorrowerCategorycode | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | kyle, mtj, srdjan |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 15407 | ||
Bug Blocks: | 16846 | ||
Attachments: |
Bug 16852: Remove GetBorrowerCategorycode
Bug 16852: Remove GetBorrowerCategorycode Bug 16852: Remove GetBorrowerCategorycode [PASSED QA] Bug 16852: Remove GetBorrowerCategorycode |
Description
Jonathan Druart
2016-07-04 17:08:05 UTC
Created attachment 53097 [details] [review] Bug 16852: Remove GetBorrowerCategorycode And use Koha::Patron->categorycode instead Test plan: - Restrict a patron attribute to a patron category - Use the batch patron modification tool to update a patron of this category You should not see the the patron attribute This would ideally go one step further: If we are doing Koha::Patrons->find( $data{borrowernumber} ) there's no reason to do it again a couple of lines below: C4/Members.pm: my $rs = $schema->resultset('Borrower')->search({ borrowernumber => $new_borrower->{borrowernumber}, }); tools/modborrowers.pl: Two for my $borrowernumber ( @borrowernumbers ) {} loops should be merged (In reply to Srdjan Jankovic from comment #2) Hi Srdjan, Yes you are right, both remarks are valid. I'd prefer to do that changes on another report. Created attachment 55579 [details] [review] Bug 16852: Remove GetBorrowerCategorycode And use Koha::Patron->categorycode instead Test plan: - Restrict a patron attribute to a patron category - Use the batch patron modification tool to update a patron of this category You should not see the the patron attribute Created attachment 56388 [details] [review] Bug 16852: Remove GetBorrowerCategorycode And use Koha::Patron->categorycode instead Test plan: - Restrict a patron attribute to a patron category - Use the batch patron modification tool to update a patron of this category You should not see the the patron attribute Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Created attachment 57057 [details] [review] [PASSED QA] Bug 16852: Remove GetBorrowerCategorycode And use Koha::Patron->categorycode instead Test plan: - Restrict a patron attribute to a patron category - Use the batch patron modification tool to update a patron of this category You should not see the the patron attribute Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 16.11, thanks Jonathan! enhancement, passing for 16.05 |