Bug 16853

Summary: Move changepassword to Koha::Patron->update_password
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: kyle, tomascohen, veron
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Medium patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 16849    
Bug Blocks: 16846, 19920    
Attachments: Bug 16853: Move changepassword to Koha::Patron->update_password
Bug 16853: Move changepassword to Koha::Patron->update_password
Bug 16853: Move changepassword to Koha::Patron->update_password
Bug 16853: Move changepassword to Koha::Patron->update_password

Description Jonathan Druart 2016-07-04 17:08:44 UTC

    
[+] Comment 1 Jonathan Druart 2016-07-04 17:18:58 UTC Comment hidden (obsolete)
[+] Comment 2 Marc Véron 2016-07-05 15:18:19 UTC Comment hidden (obsolete)
[+] Comment 3 Jonathan Druart 2016-07-09 13:18:33 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2016-07-09 13:18:46 UTC
Patch rebased against master.
Comment 5 Tomás Cohen Arazi (tcohen) 2016-07-15 14:00:59 UTC
Created attachment 53435 [details] [review]
Bug 16853: Move changepassword to Koha::Patron->update_password

This patch moves the code from C4::Members::changepassword to
Koha::Patron->update_password

Test plan:
Change your password at the OPAC and the staff interface
This should work as before

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
I rebased this on top of 16849 because they were conflicting.
Tests pass, code looks good (as usual) and I checked both OPAC
and staff password change work as expected.
Comment 6 Tomás Cohen Arazi (tcohen) 2016-07-15 14:02:25 UTC
Added bug 16849 as a dependency because otherwise they conflict. I rebased this one on top of the other.
Comment 7 Kyle M Hall (khall) 2016-07-15 18:09:49 UTC
Pushed to master for 16.11, thanks Jonathan!