Bug 16854

Summary: request.tt: Logic to display messages broken
Product: Koha Reporter: Marc Véron <veron>
Component: CirculationAssignee: Marc Véron <veron>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: frederic, gmcharlt, hector.hecaxmmx, julian.maurice, kyle.m.hall, kyle
Version: master   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 16849    
Attachments: Bug 16854: request.tt: Logic to display messages broken
[SIGNED-OFF]Bug 16854: request.tt: Logic to display messages broken
Bug 16854: request.tt: Logic to display messages broken

Description Marc Véron 2016-07-05 11:39:27 UTC
The logic to display messages is broken in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt

To verify, examin code in line 295 and following:

[% IF ( expiry || diffbranch ) %]

This hides messages after line 301:
[% IF restricted %]
...and after line 304:
[% IF amount_outstanding && Koha.Preference('maxoutstanding') && amount_outstanding > Koha.Preference('maxoutstanding') %]
Comment 1 Marc Véron 2016-07-05 11:57:36 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-07-05 16:23:42 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-07-06 13:44:14 UTC
Created attachment 53127 [details] [review]
Bug 16854: request.tt: Logic to display messages broken

This patch fixes broken logic in

To verify, see initial comment.

To test:
- Apply patch
- Have a patron with a restricion and with outstanding fines
  greater than defined in syspref 'maxoutstanding'
- Place a hold for this patron and verify, that messages
  'Patron has restrictions' and 'Patron has outstanding fines...'

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Kyle M Hall 2016-07-08 12:53:17 UTC
Pushed to master for 16.11, thanks Marc!
Comment 5 Frédéric Demians 2016-08-01 13:24:28 UTC
Pushed in 16.05. Will be in 16.05.02.
Comment 6 Julian Maurice 2016-08-16 14:40:37 UTC
Patch pushed to 3.22.x, will be in 3.22.10