Summary: | Poor performance due to high overhead of SQL call in export.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Tools | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | f.demians, jonathan.druart, julian.maurice, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 14722 | ||
Bug Blocks: | |||
Attachments: |
Bug 16855 - Poor performance due to high overhead of SQL call in export.pl
[SIGNED-OFF] Bug 16855 - Poor performance due to high overhead of SQL call in export.pl Bug 16855 - Poor performance due to high overhead of SQL call in export.pl |
Description
Nick Clemens (kidclamp)
2016-07-05 18:12:51 UTC
Created attachment 53110 [details] [review] Bug 16855 - Poor performance due to high overhead of SQL call in export.pl This patch eliminates all columns retrieved in the biblioitems query except for biblionumber. To test: 1 - Go to tools->Export data 2 - Export using various filters and note you get expected records 3 - Apply patch 4 - Ensure exported results match results before patch Created attachment 53122 [details] [review] [SIGNED-OFF] Bug 16855 - Poor performance due to high overhead of SQL call in export.pl This patch eliminates all columns retrieved in the biblioitems query except for biblionumber. To test: 1 - Go to tools->Export data 2 - Export using various filters and note you get expected records 3 - Apply patch 4 - Ensure exported results match results before patch Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Created attachment 53138 [details] [review] Bug 16855 - Poor performance due to high overhead of SQL call in export.pl This patch eliminates all columns retrieved in the biblioitems query except for biblionumber. To test: 1 - Go to tools->Export data 2 - Export using various filters and note you get expected records 3 - Apply patch 4 - Ensure exported results match results before patch Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Quick benchmark using: use Koha::Biblioitems; my @record_ids; my $biblioitems = Koha::Biblioitems->search( {}, { join => 'items', columns => 'biblionumber' } ); while ( my $biblioitem = $biblioitems->next ) { push @record_ids, $biblioitem->biblionumber; } and use Koha::Biblioitems; my @record_ids; my $biblioitems = Koha::Biblioitems->search( {}, { join => 'items' } ); while ( my $biblioitem = $biblioitems->next ) { push @record_ids, $biblioitem->biblionumber; } gives 1.4s vs 1.7s with 8600 items. Pushed to master for Koha 16.11,t thanks Nick! Pushed in 16.05. Will be in 16.05.02. Patch pushed to 3.22.x, will be in 3.22.10 |