Summary: | patron-attr-types.tt: Get rid of warnings "Argument "" isn't numeric" | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | Architecture, internals, and plumbing | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | f.demians, julian.maurice, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 16857 - patron-attr-types.tt: Get rid of warnings "Argument "" isn't numeric"
[SIGNED-OFF] Bug 16857 - patron-attr-types.tt: Get rid of warnings "Argument "" isn't numeric" Bug 16857 - patron-attr-types.tt: Get rid of warnings "Argument "" isn't numeric" Bug 16857: Check on item.branches makes more sense |
Description
Marc Véron
2016-07-06 07:18:35 UTC
Created attachment 53123 [details] [review] Bug 16857 - patron-attr-types.tt: Get rid of warnings "Argument "" isn't numeric" To vrify: - Go to Home > Administration > Patron attribute types - Make sure you have some patron attribute types with no branches limitation - For each attribute type you get a warning in intranet-error.log: patron-attr-types.pl: Argument "" isn't numeric in numeric gt (>) at (...)/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt line 284. To test: - Appy patch - Verify that warnings no longer appear in intranet-error.log Created attachment 53158 [details] [review] [SIGNED-OFF] Bug 16857 - patron-attr-types.tt: Get rid of warnings "Argument "" isn't numeric" To vrify: - Go to Home > Administration > Patron attribute types - Make sure you have some patron attribute types with no branches limitation - For each attribute type you get a warning in intranet-error.log: patron-attr-types.pl: Argument "" isn't numeric in numeric gt (>) at (...)/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt line 284. To test: - Appy patch - Verify that warnings no longer appear in intranet-error.log Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Created attachment 53181 [details] [review] Bug 16857 - patron-attr-types.tt: Get rid of warnings "Argument "" isn't numeric" To vrify: - Go to Home > Administration > Patron attribute types - Make sure you have some patron attribute types with no branches limitation - For each attribute type you get a warning in intranet-error.log: patron-attr-types.pl: Argument "" isn't numeric in numeric gt (>) at (...)/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt line 284. To test: - Appy patch - Verify that warnings no longer appear in intranet-error.log Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 53182 [details] [review] Bug 16857: Check on item.branches makes more sense The test should be on the existence of the item.branches method/attribute Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 16.11, thanks Marc, Jonathan! Pushed in 16.05. Will be in 16.05.02. Patches pushed to 3.22.x, will be in 3.22.10 |