Summary: | Silence warnings in t/db_dependent/ILSDI_Services.t | ||
---|---|---|---|
Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
Component: | Test Suite | Assignee: | Mark Tompsett <mtompset> |
Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | minor | ||
Priority: | P5 - low | CC: | brendan, f.demians, jonathan.druart, julian.maurice, tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 16864: Silence warnings in t/db_dependent/ILSDI_Services.t
Bug 16864: Silence warnings in t/db_dependent/ILSDI_Services.t Bug 16864: Silence warnings in t/db_dependent/ILSDI_Services.t |
Description
Mark Tompsett
2016-07-06 18:17:28 UTC
Created attachment 53151 [details] [review] Bug 16864: Silence warnings in t/db_dependent/ILSDI_Services.t prove t/db_dependent/ILSDI_Services.t generates noisy output as a result of the ambiguous context of two $cgi->param() calls. By storing into scalar variables, and then using the scalar variables, the code maintains readability and fixes the problem. TEST PLAN --------- 1) prove t/db_dependent/ILSDI_Services.t -- noisy. 2) apply patch 3) prove t/db_dependent/ILSDI_Services.t -- not noisy 4) run koha qa test tools Created attachment 53730 [details] [review] Bug 16864: Silence warnings in t/db_dependent/ILSDI_Services.t prove t/db_dependent/ILSDI_Services.t generates noisy output as a result of the ambiguous context of two $cgi->param() calls. By storing into scalar variables, and then using the scalar variables, the code maintains readability and fixes the problem. TEST PLAN --------- 1) prove t/db_dependent/ILSDI_Services.t -- noisy. 2) apply patch 3) prove t/db_dependent/ILSDI_Services.t -- not noisy 4) run koha qa test tools Signed-off-by: Marc <veron@veron.ch> Created attachment 53881 [details] [review] Bug 16864: Silence warnings in t/db_dependent/ILSDI_Services.t prove t/db_dependent/ILSDI_Services.t generates noisy output as a result of the ambiguous context of two $cgi->param() calls. By storing into scalar variables, and then using the scalar variables, the code maintains readability and fixes the problem. TEST PLAN --------- 1) prove t/db_dependent/ILSDI_Services.t -- noisy. 2) apply patch 3) prove t/db_dependent/ILSDI_Services.t -- not noisy 4) run koha qa test tools Signed-off-by: Marc <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master. Should be in the November 2016 release. Thanks! Pushed in 16.05. Will be in 16.05.03. Patch pushed to 3.22.x, will be in 3.22.10 |