| Summary: | GetBorrowercategoryList(): $sth->fetchall_arrayref( {} ) throws an error | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Srdjan Jankovic <srdjan> |
| Component: | Patrons | Assignee: | Srdjan Jankovic <srdjan> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, kyle, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 16877: Redo GetBorrowercategoryList() to use Koha::Patron::Categories->search()
Bug 16877: Redo GetBorrowercategoryList() to use Koha::Patron::Categories->search() |
||
Created attachment 53212 [details] [review] Bug 16877: Redo GetBorrowercategoryList() to use Koha::Patron::Categories->search() To test: * Check the "Category" list on eg Patron attribute type maint screens Created attachment 53213 [details] [review] Bug 16877: Redo GetBorrowercategoryList() to use Koha::Patron::Categories->search() Followed plan from comment #2 * Check the "Category" list on eg Patron attribute type maint screens prove t/db_dependent/Members.t: Same results with and without patch (Test 1 fails, but not related to this patch) Signed-off-by: Marc Véron <veron@veron.ch> Note: Error with t/db_dependent/Members.t was due to a local problem. Srdjan, I have removed this subroutine on bug 15407 which is waiting for QA. I'd prefer to see it pushed and mark this one as a duplicate instead of rewriting a patch and rebasing the patchset. Would you agree? Totally. I should have looked at the bug list again when I decided not to go with the simple fix. |
Despite the DBI docs, $sth->fetchall_arrayref( {} ) throws an error on xenial. Simple {Slice => {}} would fix it. But let's take this as an opportunity to replace it with Koha::Patron::Categories->search().