Bug 16890

Summary: TestBuilder always generate datetime for dates
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Galen Charlton <gmcharlt>
Severity: normal    
Priority: P5 - low CC: f.demians, kyle
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 16891, 16907    
Attachments: Bug 16890: Make TestBuilder generate date for date columns (and not datetime)
[SIGNED-OFF] Bug 16890: Make TestBuilder generate date for date columns (and not datetime)
[PASSED QA] Bug 16890: Make TestBuilder generate date for date columns (and not datetime)

Description Jonathan Druart 2016-07-09 14:56:02 UTC
TestBuilder should not generate datetime for date columns.
Comment 1 Jonathan Druart 2016-07-09 14:58:21 UTC Comment hidden (obsolete)
Comment 2 Srdjan Jankovic 2016-07-12 02:43:50 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-07-12 21:18:24 UTC
Created attachment 53353 [details] [review]
[PASSED QA] Bug 16890: Make TestBuilder generate date for date columns (and not datetime)

TestBuilder should not generate datetime for date columns, but only for
datetime and timestamp columns.

Test plan:
Make sure the change in t/db_dependent/TestBuilder.t are consistent.
Before this patch, 1 of the 2 tests should fail.
After this patch applied, they both should pass.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Kyle M Hall 2016-07-15 15:00:21 UTC
Pushed to master for Koha 16.11, thanks Jonathan!
Comment 5 Frédéric Demians 2016-08-01 13:39:10 UTC
Pushed in 16.05. Will be in 16.05.02.