| Summary: | Re-focus on "Add item" in Lists | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Lists | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | f.demians, julian.maurice, kyle, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 11325 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 16897 - Re-focus on "Add item" in Lists
[SIGNED-OFF] Bug 16897 - Re-focus on "Add item" in Lists [PASSED QA] Bug 16897 - Re-focus on "Add item" in Lists |
||
|
Description
Fridolin Somers
2016-07-11 14:30:36 UTC
Created attachment 53267 [details] [review] Bug 16897 - Re-focus on "Add item" in Lists Bug 11325 add solved a focus on "Add item" missing in Lists page. Since revamping of this page, the add item form exists both in page. The one corrected by Bug 11325 is not visible because it checks a bad var allowaddingitem instead of can_add_biblios. This patch corrects removes the first form and corrects the second form. It moves the form at left part of page so that it is always shown (usefull when there are a lot of items). It doe not add the list name after "Add item" besause it whould be huggly for long names and because listname already exists in breadscrumbs and on top of the table. It also adds autocomplete="off" on barcode input because there can be problems with a scanning device. Test instructions: 1. Create a list 2. Make sure you have an object with an assigned barcode 3. Go to the list => The barcode entry interface should be at left and has the focus 4. Enter the barcode and press enter (or use a scanner) => The item is added to the list Created attachment 53304 [details] [review] [SIGNED-OFF] Bug 16897 - Re-focus on "Add item" in Lists Bug 11325 add solved a focus on "Add item" missing in Lists page. Since revamping of this page, the add item form exists both in page. The one corrected by Bug 11325 is not visible because it checks a bad var allowaddingitem instead of can_add_biblios. This patch removes the first form and corrects the second form. It moves the form at left part of page so that it is always shown (usefull when there are a lot of items). It does not add the list name after "Add item" besause it whould be huggly for long names and because listname already exists in breadscrumbs and on top of the table. It also adds autocomplete="off" on barcode input because there can be problems with a scanning device. Test instructions: 1. Create a list 2. Make sure you have an object with an assigned barcode 3. Go to the list => The barcode entry interface should be at left and has the focus 4. Enter the barcode and press enter (or use a scanner) => The item is added to the list Signed-off-by: Owen Leonard <oleonard@myacpl.org> This is a nice improvement, thanks! Created attachment 53351 [details] [review] [PASSED QA] Bug 16897 - Re-focus on "Add item" in Lists Bug 11325 add solved a focus on "Add item" missing in Lists page. Since revamping of this page, the add item form exists both in page. The one corrected by Bug 11325 is not visible because it checks a bad var allowaddingitem instead of can_add_biblios. This patch removes the first form and corrects the second form. It moves the form at left part of page so that it is always shown (usefull when there are a lot of items). It does not add the list name after "Add item" besause it whould be huggly for long names and because listname already exists in breadscrumbs and on top of the table. It also adds autocomplete="off" on barcode input because there can be problems with a scanning device. Test instructions: 1. Create a list 2. Make sure you have an object with an assigned barcode 3. Go to the list => The barcode entry interface should be at left and has the focus 4. Enter the barcode and press enter (or use a scanner) => The item is added to the list Signed-off-by: Owen Leonard <oleonard@myacpl.org> This is a nice improvement, thanks! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I just had a library report this as a bug - love it! (In reply to Katrin Fischer from comment #4) > I just had a library report this as a bug - love it! Thanks ! I also love my work, its always perfect ;) Pushed to master for 16.11, thanks Frido! Pushed in 16.05. Will be in 16.05.02. Patch pushed to 3.22.x, will be in 3.22.10 |