Summary: | Hold suspend button incorrectly styled in patron holds list | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | arslanone, f.demians, julian.maurice, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 16900 - Hold suspend button incorrectly styled in patron holds list
Bug 16900 - Hold suspend button incorrectly styled in patron holds list [PASSED QA] Bug 16900 - Hold suspend button incorrectly styled in patron holds list |
Description
Owen Leonard
2016-07-11 19:03:18 UTC
Created attachment 53278 [details] [review] Bug 16900 - Hold suspend button incorrectly styled in patron holds list This patch updates the style of the suspend/resume button in the list of holds displayed on the checkout page and on the patron detail page. The button is now a Bootstrap-styled button with a Font Awesome icon. To test, apply the patch and locate a patron who has holds. - On the checkout page, view the 'Holds' tab and confirm that there is a correctly-styled 'Suspend' button for each hold. - Verify that the button works correctly and looks correct when a hold has been suspended. Created attachment 53300 [details] [review] Bug 16900 - Hold suspend button incorrectly styled in patron holds list This patch updates the style of the suspend/resume button in the list of holds displayed on the checkout page and on the patron detail page. The button is now a Bootstrap-styled button with a Font Awesome icon. To test, apply the patch and locate a patron who has holds. - On the checkout page, view the 'Holds' tab and confirm that there is a correctly-styled 'Suspend' button for each hold. - Verify that the button works correctly and looks correct when a hold has been suspended. Above two requirements were tested. Works fine. As expected. Suspend link is a button, and canceling it shows resume button (both using font awesome). Hm, it appears that the button of the suspend modal is an unusual blue. Apart from that observation, this works fine :) Created attachment 53302 [details] [review] [PASSED QA] Bug 16900 - Hold suspend button incorrectly styled in patron holds list This patch updates the style of the suspend/resume button in the list of holds displayed on the checkout page and on the patron detail page. The button is now a Bootstrap-styled button with a Font Awesome icon. To test, apply the patch and locate a patron who has holds. - On the checkout page, view the 'Holds' tab and confirm that there is a correctly-styled 'Suspend' button for each hold. - Verify that the button works correctly and looks correct when a hold has been suspended. Signed-off-by: Arslan Farooq <arslanone@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 16.11, thanks Owen! Pushed in 16.05. Will be in 16.05.02. Not needed in 3.22.x |