Bug 16920

Summary: sysprefs.sql - missing comma for MaxOpenSuggestions
Product: Koha Reporter: Mark Tompsett <mtompset>
Component: Installation and upgrade (web-based installer)Assignee: Mark Tompsett <mtompset>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: gmcharlt, kyle
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 14407    
Attachments: Bug 16920: sysprefs.sql - missing comma for MaxOpenSuggestions
Bug 16920: sysprefs.sql - missing comma for MaxOpenSuggestions
Bug 16920: sysprefs.sql - missing comma for MaxOpenSuggestions

Description Mark Tompsett 2016-07-14 02:45:18 UTC
Bug 15128 accidentally missed a comma on MaxOpenSuggestions.

diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
index 29ef9c8..c9a7c7e 100644
--- a/installer/data/mysql/sysprefs.sql
+++ b/installer/data/mysql/sysprefs.sql
@@ -236,6 +236,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
 ('MaxItemsToDisplayForBatchDel','1000',NULL,'Display up to a given number of items in a single item deletionbatch.','Integer'),
 ('MaxItemsToProcessForBatchMod','1000',NULL,'Process up to a given number of items in a single item modification batch.','Integer'),
 ('maxItemsInSearchResults','20',NULL,'Specify the maximum number of items to display for each result on a page of results','free'),
+('MaxOpenSuggestions','',NULL,'Limit the number of open suggestions a patron can have at once','Integer')
 ('maxoutstanding','5','','maximum amount withstanding to be able make holds','Integer'),
 ('maxRecordsForFacets','20',NULL,NULL,'Integer'),
 ('maxreserves','50','','Define maximum number of holds a patron can place','Integer'),

This just adds it in.
Comment 1 Mark Tompsett 2016-07-14 02:50:29 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2016-07-14 03:00:07 UTC Comment hidden (obsolete)
Comment 3 Nick Clemens (kidclamp) 2016-07-14 03:02:02 UTC
Created attachment 53393 [details] [review]
Bug 16920: sysprefs.sql - missing comma for MaxOpenSuggestions

TEST PLAN
---------
1) back up DB
2) drop database koha_library;
3) create database koha_library;
4) run web browser install, choose ALL defaults
   -- notice the SQL syntax warning.
5) apply patch
6) repeat steps 2-4
   -- notice SQL syntax warning is gone.
7) run koha qa test tools
8) restore db

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Kyle M Hall 2016-07-15 14:05:26 UTC
Pushed to master for 16.11, thanks Mark!