Description
Owen Leonard
2016-07-18 16:54:59 UTC
Created attachment 53478 [details] [review] Bug 16937 - Remove "onclick" from the manage staged MARC records template This patch revises the manage staged MARC records template, removing "onclick" attributes from the markup and defining those events in the script. To test, apply the patch and go to Tools -> Manage staged MARC records. - If necessary, stage a MARC file for import. - Click the name of the staged file and then the "Import this batch into the catalog" button. The batch should be correctly imported. - Return to the list of staged MARC files. - Click the name of an imported file and then the "Undo import into catalog" button. The import should be reverted. - Return to the list of staged MARC files. - Click the "Clean" button for any record. Confirm that the batch is cleaned. - For any cleaned record, click the "Delete" button. The batch should be deleted. Hi Owen Sorry but patch doesn't apply Applying: Bug 16937 - Remove "onclick" from the manage staged MARC records template fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 16937 - Remove "onclick" from the manage staged MARC records template Created attachment 53509 [details] [review] Bug 16937 - Remove "onclick" from the manage staged MARC records template This patch revises the manage staged MARC records template, removing "onclick" attributes from the markup and defining those events in the script. To test, apply the patch and go to Tools -> Manage staged MARC records. - If necessary, stage a MARC file for import. - Click the name of the staged file and then the "Import this batch into the catalog" button. The batch should be correctly imported. - Return to the list of staged MARC files. - Click the name of an imported file and then the "Undo import into catalog" button. The import should be reverted. - Return to the list of staged MARC files. - Click the "Clean" button for any record. Confirm that the batch is cleaned. - For any cleaned record, click the "Delete" button. The batch should be deleted. (In reply to Héctor Eduardo Castro Avalos from comment #2) > Sorry but patch doesn't apply My fault: Forgot to squash all necessary commits. Please try again. Created attachment 53529 [details] [review] [SIGNED-OFF]Bug 16937: Remove "onclick" from the manage staged MARC records template This patch revises the manage staged MARC records template, removing "onclick" attributes from the markup and defining those events in the script. To test, apply the patch and go to Tools -> Manage staged MARC records. - If necessary, stage a MARC file for import. - Click the name of the staged file and then the "Import this batch into the catalog" button. The batch should be correctly imported. - Return to the list of staged MARC files. - Click the name of an imported file and then the "Undo import into catalog" button. The import should be reverted. - Return to the list of staged MARC files. - Click the "Clean" button for any record. Confirm that the batch is cleaned. - For any cleaned record, click the "Delete" button. The batch should be deleted. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised I always get "Clear all reservoir records staged in this batch? This cannot be undone." even if I click on "Delete". Created attachment 53646 [details] [review] [SIGNED-OFF] Bug 16937 [Revised] Remove "onclick" from the manage staged MARC records template This patch revises the manage staged MARC records template, removing "onclick" attributes from the markup and defining those events in the script. To test, apply the patch and go to Tools -> Manage staged MARC records. - If necessary, stage a MARC file for import. - Click the name of the staged file and then the "Import this batch into the catalog" button. The batch should be correctly imported. - Return to the list of staged MARC files. - Click the name of an imported file and then the "Undo import into catalog" button. The import should be reverted. - Return to the list of staged MARC files. - Click the "Clean" button for any record. Confirm that the batch is cleaned. - For any cleaned record, click the "Delete" button. The batch should be deleted. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised QA revision: Corrected class name so that "delete" button triggers the correct warning. Created attachment 53702 [details] [review] Bug 16937 [Revised] Remove "onclick" from the manage staged MARC records template This patch revises the manage staged MARC records template, removing "onclick" attributes from the markup and defining those events in the script. To test, apply the patch and go to Tools -> Manage staged MARC records. - If necessary, stage a MARC file for import. - Click the name of the staged file and then the "Import this batch into the catalog" button. The batch should be correctly imported. - Return to the list of staged MARC files. - Click the name of an imported file and then the "Undo import into catalog" button. The import should be reverted. - Return to the list of staged MARC files. - Click the "Clean" button for any record. Confirm that the batch is cleaned. - For any cleaned record, click the "Delete" button. The batch should be deleted. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised QA revision: Corrected class name so that "delete" button triggers the correct warning. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 16.11, thanks Owen! Pushed in 16.05. Will be in 16.05.04. |