Summary: | Add "email" and "url" classes when edit or create a vendor | ||
---|---|---|---|
Product: | Koha | Reporter: | Héctor Eduardo Castro Avalos <hector.hecaxmmx> |
Component: | Templates | Assignee: | Héctor Eduardo Castro Avalos <hector.hecaxmmx> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | f.demians, julian.maurice, kyle, oleonard, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 16944: Add "email" and "url" classes when edit or create a vendor
[SIGNED-OFF] Bug 16944: Add "email" and "url" classes when edit or create a vendor Bug 16944: Add "email" and "url" classes when edit or create a vendor |
Description
Héctor Eduardo Castro Avalos
2016-07-19 20:56:21 UTC
Created attachment 53501 [details] [review] Bug 16944: Add "email" and "url" classes when edit or create a vendor When edit or create a new vendor the two fields "email" and "website" don't test if the data provided is right. When you add a direction like "koha-community.org" without the protocol "https" the program redirect to an 404 error. To reproduce the issue: 1-Go to Acquisition and create a new Vendor 2-Fill the field Website with koha-community.org 3-Use an email without at sing (@) 4-Notice that there is no error 5-Save 6-Go to the vendor created (/cgi-bin/koha/acqui/supplier.pl?booksellerid=1) 7-Click in Website: koha-community.org -> redirect to an 404 error 8-Notice the bad mailto: To test: -Apply patch -Reproduce step 1 to 8 with the same vendor or create a new one -Enter multiple wrong and valid urls -Enter urls with and without protocols http, https, ftp -Enter wrong and valid emails NOTE: The classes used are taken from 'branches.tt' Created attachment 53504 [details] [review] [SIGNED-OFF] Bug 16944: Add "email" and "url" classes when edit or create a vendor When edit or create a new vendor the two fields "email" and "website" don't test if the data provided is right. When you add a direction like "koha-community.org" without the protocol "https" the program redirect to an 404 error. To reproduce the issue: 1-Go to Acquisition and create a new Vendor 2-Fill the field Website with koha-community.org 3-Use an email without at sing (@) 4-Notice that there is no error 5-Save 6-Go to the vendor created (/cgi-bin/koha/acqui/supplier.pl?booksellerid=1) 7-Click in Website: koha-community.org -> redirect to an 404 error 8-Notice the bad mailto: To test: -Apply patch -Reproduce step 1 to 8 with the same vendor or create a new one -Enter multiple wrong and valid urls -Enter urls with and without protocols http, https, ftp -Enter wrong and valid emails NOTE: The classes used are taken from 'branches.tt' Signed-off-by: Liz Rea <liz@catalyst.net.nz> no longer allows entering of improper website urls or incomplete email addresses. Created attachment 53683 [details] [review] Bug 16944: Add "email" and "url" classes when edit or create a vendor When edit or create a new vendor the two fields "email" and "website" don't test if the data provided is right. When you add a direction like "koha-community.org" without the protocol "https" the program redirect to an 404 error. To reproduce the issue: 1-Go to Acquisition and create a new Vendor 2-Fill the field Website with koha-community.org 3-Use an email without at sing (@) 4-Notice that there is no error 5-Save 6-Go to the vendor created (/cgi-bin/koha/acqui/supplier.pl?booksellerid=1) 7-Click in Website: koha-community.org -> redirect to an 404 error 8-Notice the bad mailto: To test: -Apply patch -Reproduce step 1 to 8 with the same vendor or create a new one -Enter multiple wrong and valid urls -Enter urls with and without protocols http, https, ftp -Enter wrong and valid emails NOTE: The classes used are taken from 'branches.tt' Signed-off-by: Liz Rea <liz@catalyst.net.nz> no longer allows entering of improper website urls or incomplete email addresses. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 16.11, thanks Hector! Pushed in 16.05. Will be in 16.05.03. Pushed to 3.22.x, will be in 3.22.10 |