Summary: | Item search sorting not working properly for most columns | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Searching | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | jonathan.druart, jschmidt, julian.maurice, kyle, mtj, tmisilo |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 16951: Fix Item search sorting
Bug 16951: Replace some more Bug 16951: Fix Item search sorting Bug 16951: Replace some more Bug 16951: Fix Item search sorting Bug 16951: Replace some more |
Description
Nick Clemens (kidclamp)
2016-07-21 01:37:31 UTC
This seems to be a regression from 3.18, as we were able to sort on call numbers before. Yes, I am pretty sure too that this worked in 3.18 - as a regression I am upping severity a bit. Created attachment 58243 [details] [review] Bug 16951: Fix Item search sorting Caused by commit ac5a1bfececb5400a77f0ebad90181f5215d5a85 Bug 16154: CGI->multi_param - Manual changes The change was wrong, we wanted to retrieve a scalar (the string), not an array. We want to retrieve a string with the different column' names, not an array of 1 element. Test plan: Launch an item search and play with column sort Created attachment 58244 [details] [review] Bug 16951: Replace some more In order to avoid warnings in the logs, $cgi->param should be forced to scalar context Created attachment 58381 [details] [review] Bug 16951: Fix Item search sorting Caused by commit ac5a1bfececb5400a77f0ebad90181f5215d5a85 Bug 16154: CGI->multi_param - Manual changes The change was wrong, we wanted to retrieve a scalar (the string), not an array. We want to retrieve a string with the different column' names, not an array of 1 element. Test plan: Launch an item search and play with column sort Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 58382 [details] [review] Bug 16951: Replace some more In order to avoid warnings in the logs, $cgi->param should be forced to scalar context Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 58384 [details] [review] Bug 16951: Fix Item search sorting Caused by commit ac5a1bfececb5400a77f0ebad90181f5215d5a85 Bug 16154: CGI->multi_param - Manual changes The change was wrong, we wanted to retrieve a scalar (the string), not an array. We want to retrieve a string with the different column' names, not an array of 1 element. Test plan: Launch an item search and play with column sort Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 58385 [details] [review] Bug 16951: Replace some more In order to avoid warnings in the logs, $cgi->param should be forced to scalar context Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 17.05, thanks Jonathan! These patches have been pushed to 16.11.x, will be in 16.11.01. Pushed to 3.22.x for 3.22.14 Pushed to 16.05.x, for 16.05.07 release |