Bug 17036

Summary: circulation.pl is vulnerable to XSS attacks
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: CirculationAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: brendan, chris, f.demians, gmcharlt, jonathan.druart, julian.maurice, kyle.m.hall, kyle, m.de.rooy
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 14568    
Attachments: Bug 17036: Fix XSS in circulation.pl
Bug 17036: Fix XSS in circulation.pl
[PASSED QA] Bug 17036: Fix XSS in circulation.pl

Description Jonathan Druart 2016-08-03 07:48:54 UTC
Reported by Dionach.
Comment 1 Jonathan Druart 2016-08-03 07:50:15 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2016-08-03 22:25:42 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-08-07 10:03:05 UTC
Created attachment 54112 [details] [review]
[PASSED QA] Bug 17036: Fix XSS in circulation.pl

Test plan:
Enter the following in the "Check out" tab:
"><script>alert('XSS')</script>

=> Without this patch you will see the alert
=> With this patch, no more alert

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Kyle M Hall (khall) 2016-08-10 13:20:14 UTC
Pushed to master for 16.11, thanks Jonthan!
Comment 5 Chris Cormack 2016-08-22 19:41:31 UTC
Pushed to 3.20.x will be in 3.20.14
Comment 6 Frédéric Demians 2016-08-23 09:31:36 UTC
Pushed in 16.05. Will be in 16.05.03.
Comment 7 Julian Maurice 2016-08-23 14:23:01 UTC
Pushed to 3.22.x, will be in 3.22.10