Bug 17038

Summary: search.pl is vulnerable to XSS attacks
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: SearchingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: brendan, chris, f.demians, jonathan.druart, julian.maurice, katrin.fischer, kyle, m.de.rooy
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 14568    
Attachments: Bug 17038: Fix XSS in catalogue/search.pl
Bug 17038: Fix XSS in catalogue/search.pl
[PASSED QA] Bug 17038: Fix XSS in catalogue/search.pl

Description Jonathan Druart 2016-08-03 13:27:21 UTC
Reported by Dionach.
Comment 1 Jonathan Druart 2016-08-03 13:28:59 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2016-08-03 22:37:06 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-08-07 09:59:49 UTC
Created attachment 54111 [details] [review]
[PASSED QA] Bug 17038: Fix XSS in catalogue/search.pl

Test plan:
Search for something like:
  \";alert(1)//135

=> Without this patch you will see the alert
=> With this patch, no more alert

Note that this fix the parameters idx, q and op

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Kyle M Hall 2016-08-10 13:21:29 UTC
Pushed to master for 16.11, thanks Jonathan!
Comment 5 Chris Cormack 2016-08-22 19:40:22 UTC
Pushed to 3.20.x will be in 3.20.14, leaving as pushed to master for the other rmaints
Comment 6 Frédéric Demians 2016-08-23 09:32:19 UTC
Pushed in 16.05. Will be in 16.05.03.
Comment 7 Julian Maurice 2016-08-23 14:23:28 UTC
Pushed to 3.22.x, will be in 3.22.10