| Summary: | Wrong destination for 'api' directory | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Installation and upgrade (command-line installer) | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | benjamin.rokseth, brendan, f.demians, julian.maurice |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 13799 | ||
| Bug Blocks: | 17030 | ||
| Attachments: |
Bug 17044: Fix wrong destination for 'api' directory
Bug 17044: Fix wrong destination for 'api' directory Bug 17044: Fix wrong destination for 'api' directory |
||
|
Description
Tomás Cohen Arazi (tcohen)
2016-08-03 17:32:08 UTC
Created attachment 53964 [details] [review] Bug 17044: Fix wrong destination for 'api' directory The original Makefile.PL tweak missed to trim the directory name thus repeating the 'api' directory like in 'api/api'. To test: - Make a standard install (for example in /usr/share/koha => FAIL: check /usr/share/koha/api/api exists - Make a single install (for example in /home/tcohen/koha-single) => FAIL: check /home/tcohen/koha-single/api/api exists - Apply the patch - Make a standard install (for example in /usr/share/koha => SUCCESS: check /usr/share/koha/api exists and doesn't contain a nested 'api' dir - Make a single install (for example in /home/tcohen/koha-single) => SUCCESS: check /home/tcohen/koha-single/api exists and doesn't contain a nested 'api' dir - Sign off :-D Note: this affects the packages too, as the standard install is used as a basis. Created attachment 53974 [details] [review] Bug 17044: Fix wrong destination for 'api' directory The original Makefile.PL tweak missed to trim the directory name thus repeating the 'api' directory like in 'api/api'. To test: - Make a standard install (for example in /usr/share/koha => FAIL: check /usr/share/koha/api/api exists - Make a single install (for example in /home/tcohen/koha-single) => FAIL: check /home/tcohen/koha-single/api/api exists - Apply the patch - Make a standard install (for example in /usr/share/koha => SUCCESS: check /usr/share/koha/api exists and doesn't contain a nested 'api' dir - Make a single install (for example in /home/tcohen/koha-single) => SUCCESS: check /home/tcohen/koha-single/api exists and doesn't contain a nested 'api' dir - Sign off :-D Note: this affects the packages too, as the standard install is used as a basis. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Good catch Thomas! Have been scratching my head on this one, and will remove my symlink as soon as this is in master ;) (In reply to Benjamin Rokseth from comment #3) > Good catch Thomas! > Have been scratching my head on this one, and will remove my symlink as soon > as this is in master ;) Hehehe. Created attachment 54048 [details] [review] Bug 17044: Fix wrong destination for 'api' directory The original Makefile.PL tweak missed to trim the directory name thus repeating the 'api' directory like in 'api/api'. To test: - Make a standard install (for example in /usr/share/koha => FAIL: check /usr/share/koha/api/api exists - Make a single install (for example in /home/tcohen/koha-single) => FAIL: check /home/tcohen/koha-single/api/api exists - Apply the patch - Make a standard install (for example in /usr/share/koha => SUCCESS: check /usr/share/koha/api exists and doesn't contain a nested 'api' dir - Make a single install (for example in /home/tcohen/koha-single) => SUCCESS: check /home/tcohen/koha-single/api exists and doesn't contain a nested 'api' dir - Sign off :-D Note: this affects the packages too, as the standard install is used as a basis. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the November 2016 release. Thanks! Pushed in 16.05. Will be in 16.05.03. Patch pushed to 3.22.x, will be in 3.22.10 |