| Summary: | Add classes to different note types to allow for styling on checkins page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Circulation | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | f.demians, gmcharlt, julian.maurice, kyle.m.hall, lisettepalouse+koha |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 17055 - Add classes to different note types to allow for styling on checkins page
[SIGNED-OFF] Bug 17055 - Add classes to different note types to allow for styling on checkins page [PASSED QA] Bug 17055 - Add classes to different note types to allow for styling on checkins page |
||
|
Description
Kyle M Hall (khall)
2016-08-05 13:56:43 UTC
Created attachment 54046 [details] [review] Bug 17055 - Add classes to different note types to allow for styling on checkins page Returned items may have 3 kinds of notes, patron, item public, and item non-public. However, the html markup for them does not allow us to distinguish which type we are seeing. It would be good to add classes for each of these note types. Test Plan: 1) Check out an item to a patron 2) Add a patron note, a public item note, and a non-public item note to the patron and item you used 3) Check in the item and instead the html, note the each note span now has a class to distinguish which type of note is being displayed. Created attachment 54047 [details] [review] [SIGNED-OFF] Bug 17055 - Add classes to different note types to allow for styling on checkins page Returned items may have 3 kinds of notes, patron, item public, and item non-public. However, the html markup for them does not allow us to distinguish which type we are seeing. It would be good to add classes for each of these note types. Test Plan: 1) Check out an item to a patron 2) Add a patron note, a public item note, and a non-public item note to the patron and item you used 3) Check in the item and instead the html, note the each note span now has a class to distinguish which type of note is being displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Current patch-complexity: Trivial patch Created attachment 54108 [details] [review] [PASSED QA] Bug 17055 - Add classes to different note types to allow for styling on checkins page Returned items may have 3 kinds of notes, patron, item public, and item non-public. However, the html markup for them does not allow us to distinguish which type we are seeing. It would be good to add classes for each of these note types. Test Plan: 1) Check out an item to a patron 2) Add a patron note, a public item note, and a non-public item note to the patron and item you used 3) Check in the item and instead the html, note the each note span now has a class to distinguish which type of note is being displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 16.11! Pushed in 16.05. Will be in 16.05.03. Pushed to 3.22.x, will be in 3.22.10 |