| Summary: | empty list item in opac-reserves.tt | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Eric Phetteplace <ephetteplace> |
| Component: | OPAC | Assignee: | Eric Phetteplace <ephetteplace> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | brendan, f.demians, julian.maurice, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: |
patch
Bug 17068 - Empty li in holds request page fixed patch Bug 17068: empty <li> in opac-reserve.tt Bug 17068: empty <li> in opac-reserve.tt |
||
Created attachment 54074 [details] [review] patch Created attachment 54076 [details] [review] Bug 17068 - Empty li in holds request page To test: PLace ahold via the opadc with notes enables Notice an empty li in the source Applypatch No kore emtpy li Created attachment 54078 [details] [review] fixed patch patch with appropriate headers, should work with git-bz now Created attachment 54081 [details] [review] Bug 17068: empty <li> in opac-reserve.tt empty HTML list item on 'holds' page, to test: - sign in as user - attempt to place hold - view source in between 'holds note' textarea & <!-- ITEM HOLDS --> comment - note empty <li> - apply patch - repeat process above up until patch - no more empty <li> Signed-off-by: Jason Robb <jrobb@sekls.org> Created attachment 54082 [details] [review] Bug 17068: empty <li> in opac-reserve.tt empty HTML list item on 'holds' page, to test: - sign in as user - attempt to place hold - view source in between 'holds note' textarea & <!-- ITEM HOLDS --> comment - note empty <li> - apply patch - repeat process above up until patch - no more empty <li> Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to Master - Should be in the November 2016 release! Thanks and welcome to the community Eric! Pushed in 16.05. Will be in 16.05.03. Patch pushed to 3.22.x, will be in 3.22.10 |
There's an empty <li> in opac-reserves.tt around line 280: </li> [% END # / IF OpacHoldNotes %] <li> </li> [% IF bibitemloo.itemholdable %] <!-- ITEM HOLDS --> etc... I'll add a patch in a bit that just deletes this tag. Testing plan: - sign in as user, go to place a hold - view source on the holds page, find empty <li> in between the "hold notes" textarea and the <!-- ITEM HOLDS --> comment - apply patch - revisit holds page - no more empty list item