Bug 17068

Summary: empty list item in opac-reserves.tt
Product: Koha Reporter: Eric Phetteplace <ephetteplace>
Component: OPACAssignee: Eric Phetteplace <ephetteplace>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: brendan, f.demians, julian.maurice, nick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: patch
Bug 17068 - Empty li in holds request page
fixed patch
Bug 17068: empty <li> in opac-reserve.tt
Bug 17068: empty <li> in opac-reserve.tt

Description Eric Phetteplace 2016-08-06 17:39:42 UTC
There's an empty <li> in opac-reserves.tt around line 280:

</li>
                                                        [% END # / IF OpacHoldNotes %]

                                                        <li>
                                                        </li>
                                                        [% IF bibitemloo.itemholdable %]
                                                            <!-- ITEM HOLDS -->

etc...

I'll add a patch in a bit that just deletes this tag.

Testing plan:

- sign in as user, go to place a hold
- view source on the holds page, find empty <li> in between the "hold notes" textarea and the <!-- ITEM HOLDS --> comment
- apply patch
- revisit holds page
- no more empty list item
Comment 1 Eric Phetteplace 2016-08-06 17:47:13 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens (kidclamp) 2016-08-06 18:55:12 UTC Comment hidden (obsolete)
Comment 3 Eric Phetteplace 2016-08-06 19:17:35 UTC Comment hidden (obsolete)
Comment 4 Jason Robb 2016-08-06 21:29:31 UTC Comment hidden (obsolete)
Comment 5 Nick Clemens (kidclamp) 2016-08-06 22:34:53 UTC
Created attachment 54082 [details] [review]
Bug 17068: empty <li> in opac-reserve.tt

empty HTML list item on 'holds' page, to test:
- sign in as user
- attempt to place hold
- view source in between 'holds note' textarea & <!-- ITEM HOLDS --> comment
- note empty <li>
- apply patch
- repeat process above up until patch
- no more empty <li>

Signed-off-by: Jason Robb <jrobb@sekls.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Brendan Gallagher 2016-08-07 02:46:13 UTC
Pushed to Master - Should be in the November 2016 release!  Thanks and welcome to the community Eric!
Comment 7 Frédéric Demians 2016-08-07 07:40:43 UTC
Pushed in 16.05. Will be in 16.05.03.
Comment 8 Julian Maurice 2016-08-17 13:58:20 UTC
Patch pushed to 3.22.x, will be in 3.22.10