Summary: | Incorrect comparison operator used in edifactmsgs.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | Acquisitions | Assignee: | Colin Campbell <colin.campbell> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | f.demians, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch
[SIGNED-OFF] Bug 17081 Incorrect comparison operator used in edifactmsgs.pl [PASSED QA] Bug 17081 Incorrect comparison operator used in edifactmsgs.pl |
Description
Colin Campbell
2016-08-08 15:08:59 UTC
Created attachment 54173 [details] [review] Proposed patch To test apply the patch and the warning should no longer appear in the error log Created attachment 54229 [details] [review] [SIGNED-OFF] Bug 17081 Incorrect comparison operator used in edifactmsgs.pl Numeric comparison operator is used where string comparison required, resulting in the following warning in the log: 'Argument "delete" isn't numeric in numeric eq (==).' This patch corrects it to use 'eq' not '==' to compare strings. To test, apply the patch and go to Acquisitions -> EDIFACT messages. Delete an EDIFACT message. There should be no error in the error log. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 54248 [details] [review] [PASSED QA] Bug 17081 Incorrect comparison operator used in edifactmsgs.pl Numeric comparison operator is used where string comparison required, resulting in the following warning in the log: 'Argument "delete" isn't numeric in numeric eq (==).' This patch corrects it to use 'eq' not '==' to compare strings. To test, apply the patch and go to Acquisitions -> EDIFACT messages. Delete an EDIFACT message. There should be no error in the error log. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 16.11, thanks Colin! Pushed in 16.05. Will be in 16.05.03. |