Summary: | Translatability: Fix sentence splitting in member.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | I18N/L10N | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | f.demians, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 17082: Translatability: Fix sentence splitting in member.tt
[SIGNED-OFF] Bug 17082: Translatability: Fix sentence splitting in member.tt [PASSED QA] Bug 17082: Translatability: Fix sentence splitting in member.tt |
Description
Marc Véron
2016-08-08 15:46:02 UTC
Created attachment 54174 [details] [review] Bug 17082: Translatability: Fix sentence splitting in member.tt This patch fixes sentences splitting in file koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt Fix is done with a new .inc file because the code is the same as in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt To test: - Carefully review code changes - Test on a fresh install without example data (or save database and test with empty tables 'branches' and 'categories') - Go to Home > Patrons (members-home.pl) - Verify that a warnings appears aubout missing libraries and patron categories - Try to add a new patron (memberentry.pl) - Verify that the same messages are triggered - Verify that messages disappear as appropriate as soon as a library and a patron category are defined. Created attachment 54227 [details] [review] [SIGNED-OFF] Bug 17082: Translatability: Fix sentence splitting in member.tt This patch fixes sentences splitting in file koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt Fix is done with a new .inc file because the code is the same as in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt To test: - Carefully review code changes - Test on a fresh install without example data (or save database and test with empty tables 'branches' and 'categories') - Go to Home > Patrons (members-home.pl) - Verify that a warnings appears aubout missing libraries and patron categories - Try to add a new patron (memberentry.pl) - Verify that the same messages are triggered - Verify that messages disappear as appropriate as soon as a library and a patron category are defined. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Note: Filed Bug 17093 for JS error on patron entry form. Created attachment 54249 [details] [review] [PASSED QA] Bug 17082: Translatability: Fix sentence splitting in member.tt This patch fixes sentences splitting in file koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt Fix is done with a new .inc file because the code is the same as in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt To test: - Carefully review code changes - Test on a fresh install without example data (or save database and test with empty tables 'branches' and 'categories') - Go to Home > Patrons (members-home.pl) - Verify that a warnings appears aubout missing libraries and patron categories - Try to add a new patron (memberentry.pl) - Verify that the same messages are triggered - Verify that messages disappear as appropriate as soon as a library and a patron category are defined. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Note: Filed Bug 17093 for JS error on patron entry form. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 16.11, thanks Marc! |