Summary: | REST API: Reword borrowers to patrons in Swagger tags for holds | ||
---|---|---|---|
Product: | Koha | Reporter: | Lari Taskula <lari.taskula> |
Component: | Web services | Assignee: | Lari Taskula <lari.taskula> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | josef.moravec, kyle, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 13903 | ||
Bug Blocks: | |||
Attachments: |
Bug 17086: Reword borrowers to patrons in Swagger tags for holds
[SIGNED-OFF] Bug 17086: Reword borrowers to patrons in Swagger tags for holds [PASSED QA] Bug 17086: Reword borrowers to patrons in Swagger tags for holds |
Description
Lari Taskula
2016-08-09 11:41:18 UTC
Created attachment 54197 [details] [review] Bug 17086: Reword borrowers to patrons in Swagger tags for holds Routes for holds have tags called "borrowers". We should use "patrons" instead in order not to have both (endpoints for patrons already add "patrons"). This patch changes the tags from borrowers to patrons in: GET /holds POST /holds Created attachment 57351 [details] [review] [SIGNED-OFF] Bug 17086: Reword borrowers to patrons in Swagger tags for holds Routes for holds have tags called "borrowers". We should use "patrons" instead in order not to have both (endpoints for patrons already add "patrons"). This patch changes the tags from borrowers to patrons in: GET /holds POST /holds Signed-off-by: Josef Moravec <josef.moravec@gmail.com> I see more issues with terminology in the holds file: - reserve should be renamed to be hold in the descriptions, example: Internal reserve identifier - Found status = Hold status (could also be cancelled) - Branch code = Library code - Borrower internal identifier = Patron internal identifier etc. Created attachment 57671 [details] [review] [PASSED QA] Bug 17086: Reword borrowers to patrons in Swagger tags for holds Routes for holds have tags called "borrowers". We should use "patrons" instead in order not to have both (endpoints for patrons already add "patrons"). This patch changes the tags from borrowers to patrons in: GET /holds POST /holds Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 16.11, thanks Lari! Blocked by deps, skipping for 16.05.x |