Summary: | Regression: Error when checking out to non-existent patron | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/circ/circulation.pl?borrowernumber=X | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 17095: (bug 16849 follow-up) Fix regression if patron does not exist
[SIGNED-OFF] Bug 17095: (bug 16849 follow-up) Fix regression if patron does not exist Bug 17095: (bug 16849 follow-up) Fix regression if patron does not exist |
Description
Owen Leonard
2016-08-09 18:47:03 UTC
Created attachment 54243 [details] [review] Bug 17095: (bug 16849 follow-up) Fix regression if patron does not exist Bug 16082, 'Display a friendly "patron does not exist" message if that's the case - circulation.pl' changed the behavior of the checkout page so that if you hit that page with a borrowernumber which doesn't exist a nice message will tell you so. Now when you do that you get an error message: Can't call method "is_debarred" on an undefined value at /circ/circulation.pl line 300. Test plan: confirm that the friendly message is back :) Created attachment 54268 [details] [review] [SIGNED-OFF] Bug 17095: (bug 16849 follow-up) Fix regression if patron does not exist Bug 16082, 'Display a friendly "patron does not exist" message if that's the case - circulation.pl' changed the behavior of the checkout page so that if you hit that page with a borrowernumber which doesn't exist a nice message will tell you so. Now when you do that you get an error message: Can't call method "is_debarred" on an undefined value at /circ/circulation.pl line 300. Test plan: confirm that the friendly message is back :) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 54391 [details] [review] Bug 17095: (bug 16849 follow-up) Fix regression if patron does not exist Bug 16082, 'Display a friendly "patron does not exist" message if that's the case - circulation.pl' changed the behavior of the checkout page so that if you hit that page with a borrowernumber which doesn't exist a nice message will tell you so. Now when you do that you get an error message: Can't call method "is_debarred" on an undefined value at /circ/circulation.pl line 300. Test plan: confirm that the friendly message is back :) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 16.11, thanks Jonathan! |