Summary: | Facet's area shows itemtypes' code instead of item's description | ||
---|---|---|---|
Product: | Koha | Reporter: | Claudio Costales <costalc> |
Component: | Searching | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, kyle |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 10937, 12478 | ||
Bug Blocks: | |||
Attachments: |
OPAC display
image Search results and comparissons Line 619 in opac-search.pl Error sample Item type description in OPAC search Bug 17134: Replace item types codes with category [SIGNED-OFF] Bug 17134: Replace item types codes with category Bug 17134: Replace item types codes with category in facets (opac) |
Description
Claudio Costales
2016-08-15 18:30:27 UTC
Created attachment 54491 [details]
OPAC display
Did you enter a description? The screenshot highlights 'Search category,' not 'Description.' Description is what should show in the facet. Hi Owen! Yes, it should show item's Description instead of code. Owen, this happens when an itemtype category (LIBRO) is assigned to an itemtype. Otherwise it works fine. Did you set up your authorised value with both descriptions? Hi Katrin, Yes, I did. See image attached. Created attachment 54493 [details]
image
Thx for the screenshot! You're welcome! It did not happen in prior versions of Koha. Owen, Katrin, would you please help me with this? It's a specific 16.05 error... Thanks a lot... Confirmed in master. I also find that searching by itemtype category doesn't work at all. No results. Claudio when you perform a search in the OPAC using an itemtype search category does it work? Owen! Thanks for working around this issue. Please see file attached. Created attachment 55364 [details]
Search results and comparissons
Owen, Reviewing my last file attached may be that comparissons between partial facet counts and total results are not important but the fact that advanced search with item category cirteria works. Plese discard file attachment in comment#13 I will attach a better one. I found the error. Line 619 in /usr/share/koha/opac/cgi-bin/opac/opac-search.pl See highlight word in image file attached. It must say: $itemtypes_nocategory Created attachment 55895 [details]
Line 619 in opac-search.pl
Hi Claudio, I tried to make your comment into a patch, but it seems like the grouping is broken on master? Not sure where my mistake is. I added BK into a group IGROUP. The search from advanced search brings up nothing - the facets don't show the group term but the normal itemtype description. Created attachment 56573 [details]
Error sample
Katrin, please see file attached. I hope this help...
There are some issues with this feature, but I think we can still try and fix the issue Claudio reported. When testing this, make sure that you use the search on the itemtype group together with another search criteria (see bug 175319 To test: - add items for at least 2 itemtypes - create an authorised_value for ITEMTYPECAT - assign your used itemtypes to that category in administration > itemtypes - search for items in combination with another search criteria (title or whatever) - verify that the facet description for item tpyes is not correct Hi Katrin! I attached a PDF with a test about this bug (item type descriptions). It is running in a production environment of mine and works fine. If you agree I can sign this bug off. Created attachment 59123 [details]
Item type description in OPAC search
Hi Claudio, first we need a patch :) Would you be able to provide one? I have added the 'Academy' keyword, as there are some students working on bugs at Catalyst IT in NZ this week, but not sure if they will get to take a look at it. Line 614 in /usr/share/koha/opac/cgi-bin/opac/opac-search.pl: ($error, $results_hashref, $facets) = $searcher->search_compat($query,$simple_query,\@sort_by,\@servers,$results_per_page,$offset,$expanded_facet,undef,$itemtypes,$query_type,$scan,1); should be replaced by this: ($error, $results_hashref, $facets) = $searcher->search_compat($query,$simple_query,\@sort_by,\@servers,$results_per_page,$offset,$expanded_facet,undef,$itemtypes_nocategory,$query_type,$scan,1); ====== Tested in 16.11.01 Created attachment 59182 [details] [review] Bug 17134: Replace item types codes with category To test: -Search in OPAC for two or more items -Note that item types display category codes rather than names -Make change to file and test in OPAC I have already tested it in 2 production installations and in a local development one. May I sign-off this bug? Created attachment 59504 [details] [review] [SIGNED-OFF] Bug 17134: Replace item types codes with category To test: -Search in OPAC for two or more items -Note that item types display category codes rather than names -Make change to file and test in OPAC Signed-off-by: Owen Leonard <oleonard@myacpl.org> It seems that this has been introduced by bug 12478. Created attachment 59572 [details] [review] Bug 17134: Replace item types codes with category in facets (opac) To test: -Search in OPAC for two or more items -Note that item types display category codes rather than names -Make change to file and test in OPAC Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master for 17.05, thanks Emma! This patch has been pushed to 16.11.x and will be in 16.11.04. At last :) |