Summary: | Fix variable scope issue in edi_accounts.pl (Internal server error with plack) | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | Staff interface | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | aleisha, f.demians, gmcharlt, kyle |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17149 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 17144: Fix variable scope issues in edi_account.pl
Bug 17144: Fix variable scope issues in edi_account.pl [PASSED QA] Bug 17144: Fix variable scope issues in edi_account.pl |
Description
Marc Véron
2016-08-18 12:00:54 UTC
Created attachment 54564 [details] [review] Bug 17144: Fix variable scope issues in edi_account.pl To reproduce: - In Staff client, go to Administration > EDI accounts - Click "+ New account" Result: Internal Server Error Plack error log says: Can't call method "param" on an undefined value at /home/marc/koha/admin/edi_accounts.pl line 157 To test: -Apply patch - Add an EDI account - Edit an EDI account - Delete an EDI account I am not able to reproduce the bug. Can you please check? (In reply to Aleisha Amohia from comment #2) > I am not able to reproduce the bug. Can you please check? It is still an issue. Clicking on "New account" results in "Internal server error" plack-error.log: Variable "$schema" is not available at /home/marc/koha/admin/edi_accounts.pl line 147. Variable "$input" is not available at /home/marc/koha/admin/edi_accounts.pl line 157. Variable "$schema" is not available at /home/marc/koha/admin/edi_accounts.pl line 159. Variable "$template" is not available at /home/marc/koha/admin/edi_accounts.pl line 161. Can't call method "param" on an undefined value at /home/marc/koha/admin/edi_accounts.pl line 157. Does not happen with patch (after re-starting plack). Created attachment 55786 [details] [review] Bug 17144: Fix variable scope issues in edi_account.pl To reproduce: - In Staff client, go to Administration > EDI accounts - Click "+ New account" Result: Internal Server Error Plack error log says: Can't call method "param" on an undefined value at /home/marc/koha/admin/edi_accounts.pl line 157 To test: -Apply patch - Add an EDI account - Edit an EDI account - Delete an EDI account Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Not sure if this is the best long term solution, but it works nicely now under Plack :) Created attachment 55800 [details] [review] [PASSED QA] Bug 17144: Fix variable scope issues in edi_account.pl To reproduce: - In Staff client, go to Administration > EDI accounts - Click "+ New account" Result: Internal Server Error Plack error log says: Can't call method "param" on an undefined value at /home/marc/koha/admin/edi_accounts.pl line 157 To test: -Apply patch - Add an EDI account - Edit an EDI account - Delete an EDI account Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 16.11, thanks Marc! Pushed in 16.05. Will be in 16.05.05. |